Repository navigation
[26.8] Fix External links check on release/26.8 - #54769
Merged
Merged
Conversation
Closes keycloak#54589 Signed-off-by: Martin Bartoš <mabartos@redhat.com> (cherry picked from commit db7c58f)
docs.redhat.com now answers every scripted request with 403, so the External links check fails for any PR that touches the documentation. The pages still exist; the site blocks automated clients the same way Weblate and iso.org do. Fixes keycloak#54762 Signed-off-by: Stan Silvert <ssilvert@redhat.com> Assisted-by: Claude Opus 5.5 (cherry picked from commit 77d1edc)
The 26.8.2 upgrade note uses https://auth.example.com/admin/realms/my-realm as an example URL. The host does not resolve, so the External links check fails on release/26.8. Other example hosts are already ignored the same way. Fixes keycloak#54764 Co-authored-by: Alexander Schwartz <alexander.schwartz@ibm.com> Signed-off-by: Stan Silvert <ssilvert@redhat.com> Assisted-by: Claude Opus 5.5
ahus1
force-pushed
the
backport-54764-26.8
branch
from
November 6, 2026 16:25
01dfaa1 to
595f1b0
Compare
ahus1
approved these changes
Nov 6, 2026
Member
There was a problem hiding this comment.
Thank you for the PR.
When backporting other people's pull request, add them to the Closes #xxx body so that the automatic labeling can mark it as backported.
You also fixed the changelog. As this link doesn't resolve, it shouldn't be rendered as a link in the docs, as people would then click on it and follow it in their browser. The correct way is to change this to a passthrough notation, so it will not be rendered as a link.
Approving. Waiting for the link check to become green. Will then merge it.
ahus1
enabled auto-merge (rebase)
November 6, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to
release/26.8so the External links check passes again.main.https://auth.example.com*. It's an example URL in the 26.8.2 upgrade note that doesn't resolve.keycloak.example.comis already ignored the same way.Fixes #54764
Closes #54589
Assisted-by: Claude Opus 5.5