8000 Ignore docs.redhat.com in the external links check by ssilvert · Pull Request #54763 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Ignore docs.redhat.com in the external links check - #54763

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
ssilvert:issue-54762-ignore-docs-redhat
Nov 6, 2026
Merged

pedroigor merged 1 commit into
keycloak:mainfrom
ssilvert:issue-54762-ignore-docs-redhat

Conversation

@ssilvert
@ssilvert ssilvert commented Nov 6, 2026
Copy link
Copy Markdown
Contributor

docs.redhat.com now returns 403 to every scripted request, so the External links check fails for any PR that changes documentation. It reports the three RHEL 7 links in the Server Administration Guide (kerberos.adoc, sssd.adoc). The pages still exist; the site's CDN blocks automated clients, as Weblate (#54589) and iso.org do.

This adds https://docs.redhat.com/* to ignored-links, next to the existing entries for sites that block CI runners.

Fixes #54762

Assisted-by: Claude Opus 5.5

docs.redhat.com now answers every scripted request with 403, so the
External links check fails for any PR that touches the documentation.
The pages still exist; the site blocks automated clients the same way
Weblate and iso.org do.

Fixes keycloak#54762

Signed-off-by: Stan Silvert <ssilvert@redhat.com>
Assisted-by: Claude Opus 5.5
@ssilvert
ssilvert requested a review from a team as a code owner November 6, 2026 14:11
Copilot AI balanced review requested due to automatic review settings November 6, 2026 14:11
@ssilvert ssilvert self-assigned this Nov 6, 2026
8000 Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Red Hat documentation link-check exclusion.

No open issues 🎉

What changed in this PR

Prevents false failures in the documentation external-link check by excluding docs.redhat.com, which returns HTTP 403 to automated clients, addressing #54762.

Changes:

  • Adds https://docs.redhat.com/* to the existing ignored-link list.
  • Documents that the exclusion is due to automated-request blocking rather than unavailable pages.
File Description
docs/​documentation/​tests/​src/​test/​resources/​ignored-links Excludes Red Hat documentation URLs and explains the CI-related reason.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External links check fails because docs.redhat.com returns 403 to CI runners

3 participants

0