8000 Open masthead dropdowns towards the page in RTL locales by marsluca · Pull Request #54402 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Open masthead dropdowns towards the page in RTL locales #54402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edewit merged 1 commit into from
Oct 28, 2026
Merged

Open masthead dropdowns towards the page in RTL locales #54402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/apps/admin-ui/src/components/help-enabler/HelpHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const HelpHeader = () => {
return (
<Dropdown
popperProps={{
position: "right",
position: "end",
}}
=> setOpen(isOpen)}
isOpen={open}
Expand Down
45 changes: 45 additions & 0 deletions js/apps/admin-ui/test/masthead/main.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,49 @@ test.describe.serial("Masthead tests", () => {
await assertAxeViolations(page);
});
});

test.describe.serial("Right-to-left view", () => {
const realmName = `test-realm-${uuid()}`;
const username = `test-user-${uuid()}`;

test.beforeAll(async () => {
await adminClient.createRealm(realmName, {
enabled: true,
internationalizationEnabled: true,
supportedLocales: ["en", "ar"],
});
const { id } = await adminClient.createUser({
realm: realmName,
username,
enabled: true,
emailVerified: true,
credentials: [{ type: "password", value: "test" }],
firstName: "Test",
lastName: "User",
email: "test@keycloak.org",
attributes: { locale: ["ar"] },
});
await adminClient.addClientRoleToUser(
id!,
"realm-management",
["realm-admin"],
realmName,
);
});

test.afterAll(() => adminClient.deleteRealm(realmName));

test("Help menu opens inside the viewport", async ({ page }) => {
await logout(page);
await login(page, { realm: realmName, username, password: "test" });
await expect(page.locator("html")).toHaveAttribute("dir", "rtl");
await clickGlobalHelp(page);
const menu = page.getByRole("menu");
// Popper sets this attribute once the menu is in its final position
await expect(
page.locator("[data-popper-placement]", { has: menu }),
).toBeVisible();
await expect(menu).toBeInViewport({ ratio: 1 });
});
});
});
2 changes: 1 addition & 1 deletion js/libs/ui-shared/src/masthead/KeycloakDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const KeycloakDropdown = ({
<Dropdown
{...rest}
popperProps={{
position: "right",
position: "end",
}}
=> setOpen(isOpen)}
toggle={(ref) => (
Expand Down
Loading
0