Repository navigation
Open masthead dropdowns towards the page in RTL locales - #54402
Merged
Merged
Conversation
The masthead dropdowns used popper position "right", which PatternFly keeps physical. In RTL the toggles sit near the left edge, so the Help menu opened past the left edge of the screen. Use "end", which follows the text direction. LTR placement is unchanged. Closes keycloak#54359 Signed-off-by: Luca Marsella <34103646+marsluca@users.noreply.github.com>
edewit
approved these changes
Oct 28, 2026
edewit
enabled auto-merge (squash)
October 28, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54359
The masthead dropdowns use popper position "right", which PatternFly treats as a physical side. In RTL locales the toggles sit near the left edge, so the Help menu opened off the left side of the screen (around -350 px at 1100 and 1440 px wide).
I switched KeycloakDropdown and HelpHeader to "end", which PatternFly resolves to right in LTR and to left in RTL. LTR placement stays the same.
Testing:
test/masthead/main.spec.ts: it logs in as a user with the Arabic locale and checks that the Help menu is fully inside the viewport. It fails on main and passes with this change.A few dropdowns outside the masthead also use "right". I didn't touch them to keep this PR to the issue.
AI-assisted (Claude Code).