Repository navigation
backport 53182 26.7 - #53192
Closed
stianst wants to merge 1 commit into
Closed
backport 53182 26.7#53192stianst wants to merge 1 commit into
stianst wants to merge 1 commit into
Conversation
Closes keycloak#52974 Closes keycloak#52972 Signed-off-by: stianst <stianst@gmail.com> (cherry picked from commit 1bf99e3)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The troubleshooting documentation incorrectly applies hostname SAN requirements to all TLS certificates.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Backports the Bouncy Castle FIPS upgrade addressing two high-severity vulnerabilities to Keycloak 26.7.
Changes:
- Upgrades coordinated Bouncy Castle FIPS dependencies.
- Updates provider-version assertions and documentation.
- Adds a SAN-enabled localhost test certificate.
| File | Description |
|---|---|
pom.xml |
Updates FIPS dependency versions. |
FipsDistTest.java |
Updates the expected provider version. |
fips.adoc |
Updates output and troubleshooting guidance. |
keycloak-truststore.pem |
Adds the SAN-enabled test certificate. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+301
to
+303
| BouncyCastle FIPS requires TLS certificates with a Subject Alternative Name (SAN), with no fallback to using | ||
| the Common Name (CN) from the certificate. Due to an issue in older versions of BouncyCastle FIPS the fallback was | ||
| enabled by default, which is no longer the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.