Repository navigation
Upgrade BouncyCastle FIPS - #53182
Merged
Merged
Conversation
Closes keycloak#52974 Closes keycloak#52972 Signed-off-by: stianst <stianst@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The troubleshooting guide associates SAN remediation with an error that instead indicates a missing client-supplied hostname.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Upgrades Bouncy Castle FIPS dependencies to patched versions addressing the referenced CVEs.
Changes:
- Updates the coordinated Bouncy Castle FIPS dependency set.
- Refreshes provider-version assertions and documentation.
- Regenerates test certificates and truststores with SAN support.
| File | Description |
|---|---|
pom.xml |
Updates FIPS dependency versions. |
docs/guides/server/fips.adoc |
Updates version output and troubleshooting guidance. |
quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/FipsDistTest.java |
Updates expected provider version. |
tests/base/src/test/resources/keycloak-truststore.bcfks |
Refreshes test truststore. |
tests/base/src/test/resources/keycloak-truststore.pem |
Adds the SAN-enabled localhost certificate. |
tests/base/src/test/resources/keycloak.bcfks |
Refreshes the server test keystore. |
tests/base/src/test/resources/org/keycloak/tests/cli/keycloak.truststore |
Refreshes the CLI test truststore. |
testsuite/integration-arquillian/servers/app-server/jboss/common/keystore/keycloak.truststore |
Refreshes the application-server truststore. |
testsuite/integration-arquillian/servers/auth-server/common/fips/keycloak-fips.keystore.bcfks |
Refreshes the FIPS BCFKS keystore. |
testsuite/integration-arquillian/servers/auth-server/common/fips/keycloak-fips.keystore.pkcs12 |
Refreshes the FIPS PKCS12 keystore. |
testsuite/integration-arquillian/servers/auth-server/common/fips/keycloak-fips.truststore.bcfks |
Refreshes the FIPS BCFKS truststore. |
testsuite/integration-arquillian/servers/auth-server/common/fips/keycloak-fips.truststore.pkcs12 |
Refreshes the FIPS PKCS12 truststore. |
testsuite/integration-arquillian/servers/auth-server/common/keystore/keycloak.jks |
Refreshes the authentication-server keystore. |
testsuite/integration-arquillian/servers/auth-server/common/keystore/keycloak.truststore |
Refreshes the authentication-server truststore. |
testsuite/integration-arquillian/tests/base/src/test/resources/keystore/keycloak.jks |
Refreshes the integration-test keystore. |
testsuite/integration-arquillian/tests/base/src/test/resources/keystore/keycloak.truststore |
Refreshes the integration-test truststore. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+305
to
+306
| If you see an error such as `No hostname specified for HTTPS endpoint ID check` the recommended solution is to | ||
| update the certificates to include a Subject Alternative Name (SAN). |
Contributor
Author
There was a problem hiding this comment.
This is the exact error we observed in testing, we've not seen the one suggested by Copilot
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The troubleshooting guidance inaccurately applies hostname SAN requirements to all TLS certificates and cites an error unrelated to missing SANs.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Comment on lines
+301
to
+303
| BouncyCastle FIPS requires TLS certificates with a Subject Alternative Name (SAN), with no fallback to using | ||
| the Common Name (CN) from the certificate. Due to an issue in older versions of BouncyCastle FIPS the fallback was | ||
| enabled by default, which is no longer the case. |
rmartinc
approved these changes
Sep 25, 2026
Closed
tsaarni
pushed a commit
to Nordix/keycloak
that referenced
this pull request
Oct 14, 2026
Closes keycloak#52974 Closes keycloak#52972 (cherry picked from commit 1bf99e3) Signed-off-by: stianst <stianst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52974
Closes #52972
Signed-off-by: stianst stianst@gmail.com