Repository navigation
Select org fgap - #51715
Closed
theohh0 wants to merge 21 commits into
Closed
Select org fgap#51715theohh0 wants to merge 21 commits into
theohh0 wants to merge 21 commits into
Conversation
theohh0
force-pushed
the
select-org-fgap
branch
from
August 13, 2026 18:45
45fe269 to
9634b6a
Compare
Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
This reverts commit 01ec9d9428890fa385e558a65d18b0bc55e945ea. Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
This reverts commit 6ee7e7a. Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Closes keycloak#51400 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
…es (keycloak#51562) Bumps the actions-dependencies group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [azure/login](https://github.com/azure/login) | `3.0.0` | `3.0.1` | | [github/codeql-action/init](https://github.com/github/codeql-action) | `4.37.4` | `4.37.6` | | [github/codeql-action/analyze](https://github.com/github/codeql-action) | `4.37.4` | `4.37.6` | | [actions/setup-java](https://github.com/actions/setup-java) | `5.6.0` | `5.7.0` | | [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) | `4.37.4` | `4.37.6` | Bumps the actions-dependencies group with 1 update in the /.github/actions/java-setup directory: [actions/setup-java](https://github.com/actions/setup-java). Updates `azure/login` from 3.0.0 to 3.0.1 - [Release notes](https://github.com/azure/login/releases) - [Commits](Azure/login@532459e...f5d393a) Updates `github/codeql-action/init` from 4.37.4 to 4.37.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f205ea1...5595cca) Updates `github/codeql-action/analyze` from 4.37.4 to 4.37.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f205ea1...5595cca) Updates `actions/setup-java` from 5.6.0 to 5.7.0 - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@03ad4de...b6effb0) Updates `github/codeql-action/upload-sarif` from 4.37.4 to 4.37.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f205ea1...5595cca) Updates `actions/setup-java` from 5.6.0 to 5.7.0 - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@03ad4de...b6effb0) --- updated-dependencies: - dependency-name: azure/login dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-dependencies - dependency-name: github/codeql-action/init dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-dependencies - dependency-name: github/codeql-action/analyze dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-dependencies - dependency-name: actions/setup-java dependency-version: 5.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-dependencies - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.37.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-dependencies - dependency-name: actions/setup-java dependency-version: 5.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 6.4.0 to 7.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@48b55a0...8207627) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Closes keycloak#51347 Signed-off-by: Rohit Behera <126186063+r0h1tb@users.noreply.github.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Treat absent credential claims metadata as an empty claim set so client scopes without protocol mappers can issue credentials. Record proof validation failures on the credential request error event, including the OID4VCI error type and reason. Closes keycloak#51692 Signed-off-by: Shurong Cao <170531907+CAOShurong@users.noreply.github.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
closes keycloak#51690 Signed-off-by: mposolda <mposolda@gmail.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Closes keycloak#51687 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
…1689) closes keycloak#51181 Signed-off-by: mposolda <mposolda@gmail.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
closes keycloak#51348 Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
This reverts commit 01ec9d9428890fa385e558a65d18b0bc55e945ea. Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
This reverts commit 6ee7e7a. Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
theohh0
force-pushed
the
select-org-fgap
branch
from
August 13, 2026 18:49
b92c254 to
96671fb
8000
Compare
Contributor
Author
|
Messed up the commit signing - easier to just create new branch and redo the commits to be honest. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds organization selection to fine-grained admin permissions, alongside several unrelated OID4VCI, SCIM, documentation, and CI changes.
Changes:
- Adds an organization picker for FGAP resources.
- Updates OID4VCI and SCIM behavior and tests.
- Updates wallet documentation and GitHub Actions dependencies.
Reviewed changes
Copilot reviewed 25 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/base/.../OID4VCJWTIssuerEndpointTest.java |
Adds OID4VCI event assertions. |
tests/base/.../OID4VCIssuerWellKnownProviderTest.java |
Tests attestation metadata. |
tests/base/.../OID4VCIssuerTestBase.java |
Reconfigures attestation test scope. |
tests/base/.../OID4VCKeyAttestationTest.java |
Tests complete SD-JWT issuance. |
services/.../CredentialScopeRepresentation.java |
Normalizes attestation levels. |
services/.../OID4VCIssuerEndpoint.java |
Improves errors and null handling. |
server-spi-private/.../CredentialScopeModel.java |
Normalizes stored attestation levels. |
scim/model/.../UserResourceTypeProvider.java |
Resolves users through providers. |
scim/model/.../AbstractUserModelSchema.java |
Caches user-profile data. |
scim/model/.../GroupResourceTypeProvider.java |
Resolves groups through providers. |
scim/core/.../Attribute.java |
Caches attribute-name resolution. |
scim/core/.../AbstractModelSchema.java |
Reuses cached attributes. |
js/apps/admin-ui/src/user/Organizations.tsx |
Adopts modal modes. |
js/apps/admin-ui/src/permissions-configuration/resource-types/ResourceType.tsx |
Registers organization selection. |
js/apps/admin-ui/src/permissions-configuration/resource-types/OrganizationSelect.tsx |
Implements the organization picker. |
js/apps/admin-ui/src/organizations/OrganizationModal.tsx |
Adds selection mode. |
messages_en.properties |
Adds UI and event translations. |
wallet-integration.adoc |
Adds Lissi wallet guidance. |
vc-issuer-configuration.adoc |
Adds documentation anchors. |
.github/workflows/scan-dependencies.yml |
Updates pinned actions. |
.github/workflows/quarkus-next.yml |
Updates Java setup action. |
.github/workflows/codeql-analysis.yml |
Updates CodeQL actions. |
.github/workflows/ci.yml |
Updates Azure login action. |
.github/actions/pnpm-setup/action.yml |
Updates Node setup action. |
.github/actions/java-setup/action.yml |
Updates Java setup action. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| clients: ClientSelectComponent, | ||
| groups: GroupSelect, | ||
| roles: RoleSelect, | ||
| organizations: OrganizationSelect, |
Comment on lines
+81
to
+83
| <OrganizationModal | ||
| mode="add" | ||
| existingOrgs={organizations} |
| organizations: OrganizationRepresentation[], | ||
| ): string[] => organizations.map(({ id }) => id!); | ||
|
|
||
| export const OrganizationSelect = ({ |
Comment on lines
+43
to
+44
| import org.keycloak.events.Details; | ||
| import org.keycloak.events.EventType; |
Contributor
Author
|
New PR: #51717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #50830
Implements selecting which organizations to apply fine-grained admin permissions to, similar to implementation group resource selection for FGAP.
Mostly reuses
OrganizationModalcurrently used to add users to organizations.