Repository navigation
[OID4VCI] Documentation for integration with Lissi wallet - #51689
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds documentation for manually testing OID4VCI interoperability with third-party wallets (notably Lissi), while reorganizing the existing Valera wallet guidance under a shared “Testing with third-party wallets” section.
Changes:
- Introduced a new “Testing with third-party wallets” top-level section and nested Valera + Lissi wallet subsections beneath it.
- Added a full Lissi wallet integration walkthrough including tested environment, setup, auth code flow, and pre-authorized flow.
- Added missing anchors in
vc-issuer-configuration.adocso wallet integration docs can link to “Key Management” and “User setup” sections.
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/documentation/server_admin/topics/oid4vci/wallet-integration.adoc | Reorganizes wallet testing docs and adds Lissi wallet integration steps, anchors, and troubleshooting notes. |
| docs/documentation/server_admin/topics/oid4vci/vc-issuer-configuration.adoc | Adds anchors used by the wallet integration guide for stable cross-references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+312
to
+313
| For local testing, {project_name} can run on the development machine as described in the previous OID4VCI setup sections. It is assumed that {project_name} running on HTTPS | ||
| is accessible from the mobile application. Similar setup as described in the <<_oid4vci_valera_wallet_server_setup,Valera wallet server setup>> can be used. |
closes keycloak#51181 Signed-off-by: mposolda <mposolda@gmail.com>
Signed-off-by: mposolda <mposolda@gmail.com>
mposolda
force-pushed
the
51181-lissi-wallet-docs
branch
from
August 13, 2026 07:45
8c59bff to
1ec75c8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (2)
docs/documentation/server_admin/topics/oid4vci/wallet-integration.adoc:424
- Following the linked Authorization Code sequence tells the reader to click Issue to wallet, but that Account Console action creates an authorization-code offer (
preAuthorized: false), so the test no longer exercises the pre-authorized flow. After addingkc_action, the instructions should instead log in on the laptop, scan the AIA-generated offer directly, and skip that button.
. Additional steps are the same as for <<_oid4vci_lissi_wallet_authz_code_flow,Authorization code flow>>. With the exception, that with the pre-authorized code flow, the mobile
application does not request login from the user as it is assumed that user was "pre-authorized" in some other way - which in this use-case was done in fact by user authentication on the laptop to the {project_name} account console.
docs/documentation/server_admin/topics/oid4vci/wallet-integration.adoc:137
- The linked pre-authorized instructions contain an AIA payload targeting Lissi's fixed client ID. Reusing it for Valera creates an offer that Valera cannot redeem; provide a Valera-specific payload instead of directing readers to copy the Lissi value.
This issue also appears on line 423 of the same file.
Instead of REST credential-offer, it is recommended to use AIA for creating credential offer. That is easier and does not need feature `oid4vc-vci-rest-credential-offer` to be enabled.
Follow <<_oid4vci_lissi_wallet_authz_code_flow,Lissi wallet Authorization code section>> or <<_oid4vci_lissi_wallet_preauthz_flow,Lissi wallet Pre-authorized code section>> for the details.
lhanusov
approved these changes
Aug 13, 2026
Contributor
Author
|
@lhanusov Thanks! |
theohh0
pushed a commit
to theohh0/keycloak
that referenced
this pull request
Aug 13, 2026
…1689) closes keycloak#51181 Signed-off-by: mposolda <mposolda@gmail.com> Signed-off-by: theohh0 <theo.hinton-hallows@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #51181
Created new section "Testing with third-party wallets" and move both existing
Valera walletas well as newly addedLissi walletas subsections of itMinor updates to
Valera walletsection as well (but no real updates in the steps for the integration)