Repository navigation
show/update credential user attributes in admin console and account console #49218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
js/apps/account-ui/src/verifiable-credentials/UserAttributesDialog.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { useTranslation } from "react-i18next"; | ||
| import { Modal, ModalVariant } from "@patternfly/react-core"; | ||
| import { | ||
| Table, | ||
| TableVariant, | ||
| Tbody, | ||
| Td, | ||
| Th, | ||
| Thead, | ||
| Tr, | ||
| } from "@patternfly/react-table"; | ||
|
|
||
| type UserAttributesDialogProps = { | ||
| credentialScopeName: string; | ||
| userAttributes: Record<string, string[]>; | ||
| onClose: () => void; | ||
| }; | ||
|
|
||
| export const UserAttributesDialog = ({ | ||
| credentialScopeName, | ||
| userAttributes, | ||
| onClose, | ||
| }: UserAttributesDialogProps) => { | ||
| const { t } = useTranslation(); | ||
|
|
||
| return ( | ||
| <Modal | ||
| variant={ModalVariant.medium} | ||
| title={t("credentialUserAttributesFor", { credentialScopeName })} | ||
| isOpen | ||
| > | ||
| > | ||
| <Table | ||
| aria-label={t("credentialUserAttributes")} | ||
| variant={TableVariant.compact} | ||
| > | ||
| <Thead> | ||
| <Tr> | ||
| <Th>{t("credentialAttributeName")}</Th> | ||
| <Th>{t("credentialAttributeValue")}</Th> | ||
| </Tr> | ||
| </Thead> | ||
| <Tbody> | ||
| {Object.entries(userAttributes).map(([key, values]) => ( | ||
| <Tr key={key}> | ||
| <Td>{key}</Td> | ||
| <Td>{values.join(", ")}</Td> | ||
| </Tr> | ||
| ))} | ||
| </Tbody> | ||
| </Table> | ||
| </Modal> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { useTranslation } from "react-i18next"; | ||
| import { Modal, ModalVariant } from "@patternfly/react-core"; | ||
| import { | ||
| Table, | ||
| TableVariant, | ||
| Tbody, | ||
| Td, | ||
| Th, | ||
| Thead, | ||
| Tr, | ||
| } from "@patternfly/react-table"; | ||
|
|
||
| type UserAttributesDialogProps = { | ||
| credentialScopeName: string; | ||
| userAttributes: Record<string, string[]>; | ||
| onClose: () => void; | ||
| }; | ||
|
|
||
| export const UserAttributesDialog = ({ | ||
| credentialScopeName, | ||
| userAttributes, | ||
| onClose, | ||
| }: UserAttributesDialogProps) => { | ||
| const { t } = useTranslation(); | ||
|
|
||
| return ( | ||
| <Modal | ||
| variant={ModalVariant.medium} | ||
| title={t("credentialUserAttributesFor", { credentialScopeName })} | ||
| isOpen | ||
| > | ||
| > | ||
| <Table | ||
| aria-label={t("credentialUserAttributes")} | ||
| variant={TableVariant.compact} | ||
| > | ||
| <Thead> | ||
| <Tr> | ||
| <Th>{t("credentialAttributeName")}</Th> | ||
| <Th>{t("credentialAttributeValue")}</Th> | ||
| </Tr> | ||
| </Thead> | ||
| <Tbody> | ||
| {Object.entries(userAttributes).map(([key, values]) => ( | ||
| <Tr key={key}> | ||
| <Td>{key}</Td> | ||
| <Td>{values.join(", ")}</Td> | ||
| </Tr> | ||
| ))} | ||
| </Tbody> | ||
| </Table> | ||
| </Modal> | ||
| ); | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can move this to the ui-shared module so that it doesn't need to be copied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it, but with the next updates I think they might change between admin console and admin ui, I would prefer to keep them separate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 , those may very likely differ.
For me, current PR is OK.
@edewit @graziang Or it can be moved to shared module and then create separate components for admin/account in some follow-up PRs if needed? What is the preferred way here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so when the component is moved to the ui-shared module it can be used by account and by admin-ui, it's already setup this way so all that is needed it to move it (export it in the module) and change the imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but if they are going to be different anyway we can leave it like this as well