8000 show/update credential user attributes in admin console and account console by graziang · Pull Request #49218 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

show/update credential user attributes in admin console and account console - #49218

Merged
edewit merged 1 commit into
keycloak:mainfrom
graziang:issue-48926
May 22, 2026
Merged

edewit merged 1 commit into
keycloak:mainfrom
graziang:issue-48926

Conversation

@graziang
Copy link
Copy Markdown
Contributor

Closes #48926

Added a button to update credentials (update attributes) in the admin console, and also added a column in the credential list to show the current snapshot of the attributes.

In the account console, I only added a button to view the attributes.

Few screenshots:

Admin console:
Screenshot 2026-05-21 at 14 42 50

Screenshot 2026-05-21 at 14 43 41 Screenshot 2026-05-21 at 14 43 50

Account console:
Screenshot 2026-05-21 at 14 44 06

@@ -0,0 +1,51 @@
import { useTranslation } from "react-i18next";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can move this to the ui-shared module so that it doesn't need to be copied

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but with the next updates I think they might change between admin console and admin ui, I would prefer to keep them separate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 , those may very likely differ.

For me, current PR is OK.

@edewit @graziang Or it can be moved to shared module and then create separate components for admin/account in some follow-up PRs if needed? What is the preferred way here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so when the component is moved to the ui-shared module it can be used by account and by admin-ui, it's already setup this way so all that is needed it to move it (export it in the module) and change the imports

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if they are going to be different anyway we can leave it like this as well

Closes keycloak#48926

Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
@mposolda mposolda self-assigned this May 22, 2026
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graziang Nice, Thanks!

@mposolda
mposolda requested a review from edewit May 22, 2026 06:47
@edewit
edewit merged commit 36513ba into keycloak:main May 22, 2026
145 of 149 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
Closes keycloak#48926

Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OID4VCI] Support for user attributes in UI

4 participants

0