Repository navigation
Conversation
hammadxcm
force-pushed
the
migrate-organization-admin-tests
branch
from
April 17, 2026 15:53
fb8dc47 to
84cf5e0
Compare
hammadxcm
force-pushed
the
migrate-organization-admin-tests
branch
from
April 18, 2026 08:35
84cf5e0 to
5bbe800
Compare
This was referenced Apr 18, 2026
Member
|
Contributor
Author
|
Thanks @ahus1, applying all three:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent tracking issue: #47926
Part of #48178 (complements #48203 which migrated
OrganizationInvitationManagementTest).Migrates the bulk of
OrganizationTest(734 LOC) fromtestsuite/integration-arquillian/.../organization/admin/totests/base/.../organization/admin/.Migrated (18 tests)
testUpdate,testUpdateConflict,testGet,testGetAll,testSearch,testSearchByAttributes,testCountEndpoint,testDelete,testAttributes,testDomains,testWithoutDomains,testFilterEmptyDomain,testDisabledOrganizationProvider,testCount,testFailUpdateAlias,testFailDuplicatedAlias,testSpecialCharsAlias,testInvalidRedirectUri. Note thattestDomainsis migrated with one sub-check removed (see below).Kept in legacy module (1 of 19 tests)
testDeleteRealm— usesrealmsResouce(),bc.setUpIdentityProvider(), and the legacyRealmBuilder. Requires cross-realm broker scaffolding that the new framework does not expose yet; stays in the legacy module so coverage is preserved. The legacy file is trimmed to only this one test.One assertion trimmed from
testDomainsThe legacy
testDomainsincluded a one-line sub-check that "the same internet domain is allowed in a different realm" — implemented viaadminClient.realm(bc.providerRealmName()). That requires cross-realm broker setup and has been replaced with a TODO comment in the migrated test. The assertion will return once the broker infra is ported.Notable translations
testRealm()→realm.admin().Assert.assertTrue(...)→ JUnit 5assertTrue(...)(andassertTrue(condition, message)argument order in JUnit 5).getTestingClient().server(TEST_REALM_NAME).run(...)→@InjectRunOnServer RunOnServerClient.run(...).new RealmAttributeUpdater(realm.admin()).setOrganizationsEnabled(FALSE).update()(try-with-resources) → inlinerealmRep.setOrganizationsEnabled(FALSE); realm.admin().update(realmRep)with afinallyblock that restores the flag.RealmAttributeUpdaterhas no equivalent in the new framework yet.getCleanup().addCleanup(() -> ...)→realm.cleanup().add(r -> ...).@Test/Assert.*imports swapped to JUnit 5; Hamcrest unchanged.