Repository navigation
Conversation
hammadxcm
force-pushed
the
migrate-organization-member-tests
branch
from
April 17, 2026 15:53
0dc1a47 to
2eb7532
Compare
hammadxcm
8000
force-pushed
the
migrate-organization-member-tests
branch
from
April 18, 2026 08:35
2eb7532 to
979ae71
Compare
Member
|
Limiting open PRs for new contributors to two open PRs at a time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent tracking issue: #47926
Part of #48184
Migrates the API-only half of
OrganizationMemberTestfromtestsuite/integration-arquillian/.../organization/member/to the new framework undertests/base/.../organization/member/.Migrated (17 tests)
testUpdate,testUserAlreadyMemberOfOrganization,testGet,testGetMemberOrganization,testGetMemberOrganizationRequiresMembershipInCurrentOrganization,testGetAll,testDeleteUnmanagedMember,testUpdateEmailUnmanagedMember,testDeleteMembersOnOrganizationRemoval,testSearchMembers,testSearchMembersWithSqlWildcards,testAddMemberFromDifferentRealm,testMemberInMultipleOrganizations,testMembersCount,testNonMemberCanUnsetEmailThatMatchesOrg,testGetMemberOrganizationsBriefVsFullRepresentation,testGetMemberOrganizationsForbiddenForNonAdminUser.All 17 rely only on the organization admin API and cleanly map to the new framework helpers already provided by
AbstractOrganizationTest+MemberRepresentation-driven assertions.Not migrated (legacy file retains 4 tests)
testGetAllDisabledOrganizationtestGetAllDisabledOrganizationProvidertestUserFederatedBeforeTheIDPBoundWithAnOrgIsNotMembertestManagedMemberOnlyRemovedFromHomeOrganizationEach of these requires the legacy
BrokerConfigurationflow (bc.getUserLogin(),assertBrokerRegistration(...),realmsResouce().realm(bc.providerRealmName()), broker login vialoginPage). The new framework has no equivalent yet, so these stay in the legacy module until the broker infra is ported.OrganizationMemberWithLdapTestis also untouched — it depends onAbstractLDAPTestscaffolding that isn't available in the new framework.Notable translations
testRealm()→realm.admin().getCleanup().addCleanup(...)→realm.cleanup().add(r -> ...).getTestingClient().server(TEST_REALM_NAME).run(session -> ...)→@InjectRunOnServer RunOnServerClient.run(session -> ...).UserBuilder.create()→UserConfigBuilder.create()(legacyUserBuilderis not on the new-framework classpath).AdminClientUtil.createAdminClient(...)→KeycloakBuilder.builder()driven by@InjectKeycloakUrls KeycloakUrls.