Repository navigation
fix: generalizing the augmentation check - #47748
Merged
Merged
Conversation
shawkins
force-pushed
the
iss47659
branch
2 times, most recently
from
April 3, 2026 16:36
a38f003 to
1859a51
Compare
This was referenced Apr 3, 2026
vmuzikar
self-requested a review
April 7, 2026 14:51
closes: keycloak#47659 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
michalvavrik
approved these changes
Apr 8, 2026
Member
There was a problem hiding this comment.
I agree this identifies when the interceptor is used during the build-time (augmenting). I looked into Quarkus and didn't find a better way. We can register runtime-only interceptors via RunTimeConfigBuilderBuildItem (and we could add it to the static init as well), but we cannot register build-time only interceptor unless we ask Quarkus to add it. I understand why Quarkus don't want to record sys props as defaults, so for lack of a better way - LGTM. Thanks
vmuzikar
enabled auto-merge (squash)
April 29, 2026 14:06
vmuzikar
approved these changes
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Approving based on @michalvavrik's review.
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
closes: keycloak#47659 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #47659