Repository navigation
fix: hide runtime defaults during Quarkus dev mode augmentation - #47743
Closed
sachinnn99 wants to merge 1 commit into
Closed
sachinnn99 wants to merge 1 commit into
sachinnn99 wants to merge 1 commit into
Conversation
sachinnn99
force-pushed
the
fix/47659-dev-mode-srcfg01008-warning
branch
from
April 3, 2026 08:28
f4c8f11 to
93d5bb2
Compare
The existing augmentation detection only checks isRebuild() and KC_TEST_REBUILD, which are not set during Quarkus dev mode. This causes SRCFG01008 warnings when running from source with kc.log-console-output=default because runtime property values leak into the default value config source. Detect dev-mode augmentation by combining LaunchMode.DEVELOPMENT with disabled expressions, which precisely identifies when Quarkus probes for runtime defaults during dev-mode augmentation without matching dev-mode runtime or plain JUnit tests. Closes keycloak#47659 Signed-off-by: Sachin <52783123+sachinnn99@users.noreply.github.com>
sachinnn99
force-pushed
the
fix/47659-dev-mode-srcfg01008-warning
branch
from
April 3, 2026 08:39
93d5bb2 to
26e7f69
Compare
1 of 2 tasks
Contributor
|
Thank you for you interest in this issue, but after reviewing this and the other pr it seems best to be more general in how we're detecting when augmentation is running. Please see #47748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvn quarkus:devwithkc.log-console-output=defaultisRebuild()/KC_TEST_REBUILD) doesn't cover Quarkus dev mode, which manages augmentation internally without setting these flagsLaunchMode.DEVELOPMENTwith disabled expressions — this precisely identifies when Quarkus probes for runtime defaults during augmentation, without matching dev-mode runtime or plain JUnit testsChanges
PropertyMappers.getValue(): Added a second condition after the existing augmentation check that hides runtime property values whenLaunchModeisDEVELOPMENTand expressions are disabledConfigurationTest: Added test verifying runtime values are hidden during dev-mode augmentation probing and visible during normal dev-mode runtimeCloses #47659