8000 Add OpenSSF Scorecard badge to README by y-tabata · Pull Request #36127 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Add OpenSSF Scorecard badge to README - #36127

Merged
abstractj merged 1 commit into
keycloak:mainfrom
y-tabata:patch-1
Feb 19, 2025
Merged

abstractj merged 1 commit into
keycloak:mainfrom
y-tabata:patch-1

Conversation

@y-tabata
@y-tabata y-tabata commented Dec 24, 2024 •
Copy link
Copy Markdown
Contributor

Signed-off-by: Yoshiyuki Tabata <34849594+y-tabata@users.noreply.github.com>
@y-tabata
y-tabata requested a review from a team as a code owner December 24, 2024 07:33
@tnorimat tnorimat left a comment •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abstractj I think it is worth including the badge because everyone can see how much Keycloak comply with OpenSSF. What do you think about that?

@y-tabata
Copy link
Copy Markdown
Contributor Author

@abstractj Cloud you please review this?

@abstractj
abstractj commented Feb 3, 2025 •
Copy link
Copy Markdown
Contributor

@y-tabata apologies for the delay. First, I would like to thank you for proposing those changes; it is a positive step towards making Keycloak better. Before merging it, I would like us to follow up on Security Scorecards:

  • Vulnerabilities (must-have) – There's a high number of false positives reported. We need to understand how to dismiss those false positives or determine where to fix them.
  • Branch protection (optional) – Today, we have branch protection, but it seems that Scorecards is unable to detect it.
  • Packaging (optional) – We publish our packages on GitHub, but it seems that Scorecards is unable to detect them.

Fixing branch protection and packaging detection on Scorecards is optional for me, but at the same time, we cannot merge these changes without addressing the false positives. Understanding why these CVEs are being reported, even if Keycloak has already fixed and published advisories, would be beneficial.

I'd be happy to work with you on these remaining items. cc @tnorimat

@tnorimat
tnorimat commented Feb 5, 2025
Copy link
Copy Markdown
Contributor

@y-tabata Could you consider helping the items mentioned by @abstractj ?

@abstractj
Copy link
Copy Markdown
Contributor

This issue depends on ossf/scorecard#4530.

@abstractj
Copy link
Copy Markdown
Contributor

@y-tabata please check the updated comments, if you would like to collaborate, that will be more than welcome.

@abstractj
Copy link
Copy Markdown
Contributor

These changes should solve the issue #37500.

@abstractj
abstractj merged commit a1f5e14 into keycloak:main Feb 19, 2025
@y-tabata
y-tabata deleted the patch-1 branch February 20, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OpenSSF Scorecard badge to README

3 participants

0