8000 Add OAuth SIG meeting link to README by y-tabata · Pull Request #32385 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Add OAuth SIG meeting link to README - #32385

Merged
stianst merged 2 commits into
keycloak:mainfrom
Hitachi:add-meeting-link-to-readme
Oct 11, 2024
Merged

stianst merged 2 commits into
keycloak:mainfrom
Hitachi:add-meeting-link-to-readme

Conversation

@y-tabata
Copy link
Copy Markdown
Contributor

Closes #32384

@y-tabata
y-tabata requested a review from a team as a code owner August 26, 2024 07:51
@y-tabata
y-tabata force-pushed the add-meeting-link-to-readme branch from a8d8de0 to c95bbe4 Compare August 26, 2024 08:21
@y-tabata
y-tabata marked this pull request as draft August 26, 2024 08:23
@y-tabata
y-tabata force-pushed the add-meeting-link-to-readme branch from c95bbe4 to fbcf7d3 Compare September 3, 2024 00:56
@y-tabata
y-tabata marked this pull request as ready for review September 3, 2024 00:58
@tnorimat
tnorimat commented Sep 3, 2024
Copy link
Copy Markdown
Contributor

@abstractj Hello, what do you think about the PR for being aligned with CNCF project

@abstractj
Copy link
Copy Markdown
Contributor

@abstractj Hello, what do you think about the PR for being aligned with CNCF project

What exactly do you mean @tnorimat ?

Reading the proposal, I don't see any harm about having it in the README file, but I'm curious about what our @keycloak/maintainers think.

Another good alternative is the approach used by the Knative team, providing a shared calendar - https://knative.dev/docs/community/#meetings. That would make things easy to add to the website (I believe).

@y-tabata
y-tabata commented Sep 5, 2024
Copy link
Copy Markdown
Contributor Author

@abstractj
From a CNCF perspective, this proposal stems from this discussion created by Chris, the CNCF CTO.
Considering Keycloak becoming a CNCF Graduated project, he said that one of the effective ways is to up the CLOMonitor Score.
This proposal is an effort to pass the Best Practice Community meeting check.

@y-tabata
Copy link
Copy Markdown
Contributor Author

@abstractj Could you check the above comment and review this PR?

@stianst stianst left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs in the README, but rather on the website.

I'd suggest adding a section to https://www.keycloak.org/community (https://github.com/keycloak/keycloak-web/blob/main/pages/community.ftl) that lists the OAuth SIG, and also community meetings.

@y-tabata
Copy link
Copy Markdown
Contributor Author

@stianst
Thank you for your feedback.
Does it make sense to write a link to the community site's meeting section in the "Help and Documentation" section of the README, after posting information about the meetings on the community site?

@stianst
stianst commented Oct 11, 2024
Copy link
Copy Markdown
Contributor

@stianst Thank you for your feedback. Does it make sense to write a link to the community site's meeting section in the "Help and Documentation" section of the README, after posting information about the meetings on the community site?

Not sure, doesn't feel the most natural place for it. Maybe it would make more sense in the contributing section? We could definitively expand a bit on that on how people can engage by joining SIGs, finding things to work on, etc.

@y-tabata
Copy link
Copy Markdown
Contributor Author

Okay, so I'll add the information to the community site and then create a PR to add a link to it in the README.

Closes keycloak#32384

Signed-off-by: Yoshiyuki Tabata <yoshiyuki.tabata.jy@hitachi.com>
@y-tabata
y-tabata force-pushed the add-meeting-link-to-readme branch from fbcf7d3 to 0a72423 Compare October 11, 2024 07:58
@y-tabata
Copy link
Copy Markdown
Contributor Author

@stianst
I added the link to the community site in the README.

Comment thread README.md Resolved
Co-authored-by: Stian Thorgersen <stian@redhat.com>
Signed-off-by: Yoshiyuki Tabata <34849594+y-tabata@users.noreply.github.com>
@stianst
stianst requested a review from ahus1 October 11, 2024 08:48
@stianst
stianst merged commit af6f368 into keycloak:main Oct 11, 2024
@y-tabata
y-tabata deleted the add-meeting-link-to-readme branch October 11, 2024 09:18
y-tabata added a commit to y-tabata/keycloak that referenced this pull request Dec 24, 2024
Signed-off-by: Yoshiyuki Tabata <34849594+y-tabata@users.noreply.github.com>
abstractj pushed a commit that referenced this pull request Feb 19, 2025
Signed-off-by: Yoshiyuki Tabata <34849594+y-tabata@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add link of OAuth SIG meeting to README

5 participants

0