8000 fix: using regex to expand local ipv6 matching (#35736) by shawkins · Pull Request #35737 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: using regex to expand local ipv6 matching (#35736) - #35737

Merged
vmuzikar merged 1 commit into
keycloak:release/26.0from
shawkins:backport-35736-26.0
Dec 9, 2024
Merged

fix: using regex to expand local ipv6 matching (#35736)#35737
vmuzikar merged 1 commit into
keycloak:release/26.0from
shawkins:backport-35736-26.0

Conversation

@shawkins
@shawkins shawkins commented Dec 9, 2024
Copy link
Copy Markdown
Contributor

closes: #35675

Signed-off-by: Steve Hawkins shawkins@redhat.com
(cherry picked from commit 8089073)

@shawkins
fix: using regex to expand local ipv6 matching (keycloak#35736)
5e4ff37 
closes: keycloak#35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 8089073)
@shawkins
shawkins requested a review from a team as a code owner December 9, 2024 14:52
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Dec 9, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Dec 9, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginAgainWithoutRememberMe(LoginTest.java:693)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithRememberMe(LoginTest.java:633)
...

Report flaky test

@vmuzikar
vmuzikar merged commit 0bd8a1f into keycloak:release/26.0 Dec 9, 2024
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
edewit pushed a commit to edewit/keycloak that referenced this pull request Dec 11, 2024
@shawkins @edewit
fix: using regex to expand local ipv6 matching (keycloak#35736) (keyc…
0c6ea3c 
…loak#35737)

closes: keycloak#35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 8089073)
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@Eddyhanderson Eddyhanderson mentioned this pull request Dec 23, 2024
Closed
2 tasks done
@shawkins shawkins mentioned this pull request Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shawkins @vmuzikar
0