8000 fix: using regex to expand local ipv6 matching by shawkins · Pull Request #35736 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

fix: using regex to expand local ipv6 matching - #35736

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss35675
Dec 9, 2024
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss35675

Conversation

@shawkins
@shawkins shawkins commented Dec 9, 2024
Copy link
Copy Markdown
Contributor

closes: #35675

closes: keycloak#35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins requested review from jonkoops and vmuzikar December 9, 2024 13:44
@shawkins
shawkins requested a review from a team as a code owner December 9, 2024 13:44
@shawkins
shawkins commented Dec 9, 2024
Copy link
Copy Markdown
Contributor Author

Just like the ipv4 check this is not looking specifically for a valid address (it can accept invalid shorthand notation), but will match things that must be local - all zeros except for the trailing 1.

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins LGTM, thanks.

Can you please create a backport in case there's another 26.0 release?

@vmuzikar
vmuzikar enabled auto-merge (squash) December 9, 2024 14:12
@shawkins
shawkins commented Dec 9, 2024
Copy link
Copy Markdown
Contributor Author

Can you please create a backport in case there's another 26.0 release?

Yes, it will need backported to 24 as well.

@vmuzikar
vmuzikar merged commit 8089073 into keycloak:main Dec 9, 2024
shawkins added a commit to shawkins/keycloak that referenced this pull request Dec 9, 2024
closes: keycloak#35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 8089073)
shawkins added a commit to shawkins/keycloak that referenced this pull request Dec 9, 2024
closes: keycloak#35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 8089073)
vmuzikar pushed a commit that referenced this pull request Dec 9, 2024
closes: #35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 8089073)
8000 vmuzikar pushed a commit that referenced this pull request Dec 9, 2024
closes: #35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 8089073)
@edewit edewit mentioned this pull request Dec 11, 2024
edewit pushed a commit to edewit/keycloak that referenced this pull request Dec 11, 2024
…loak#35737)

closes: keycloak#35675

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 8089073)
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New install doesn't allow admin user creation

3 participants

0