8000 Revert back submitRequest to submit for saml ftl Closes (26.0) by rmartinc · Pull Request #35659 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Revert back submitRequest to submit for saml ftl Closes (26.0) - #35659

Merged
jonkoops merged 1 commit into
keycloak:release/26.0from
rmartinc:backport-35584-26.0
Dec 10, 2024
Merged

Revert back submitRequest to submit for saml ftl Closes (26.0)#35659
jonkoops merged 1 commit into
keycloak:release/26.0from
rmartinc:backport-35584-26.0

Conversation

@rmartinc
@rmartinc rmartinc commented Dec 5, 2024
Copy link
Copy Markdown
Contributor

Closes #35488

PR: #35584
Commit: e488f34
PR branch: backport-35584-26.0
Target branch: https://github.com/keycloak/keycloak/tree/release/26.0

Plain cherry-pick for #35488 in 26.0.

@rmartinc
Revert back submitRequest to submit for saml ftl
c9ec737 
Closes keycloak#35488

Signed-off-by: rmartinc <rmartinc@redhat.com>
(cherry picked from commit e488f34)
@rmartinc
rmartinc requested review from a team as code owners December 5, 2024 12:04
@rmartinc rmartinc changed the title Revert back submitRequest to submit for saml ftl Closes #35488 Revert back submitRequest to submit for saml ftl Closes (26.0) Dec 5, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Dec 5, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Dec 5, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginAgainWithoutRememberMe(LoginTest.java:693)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithEmailUserAndRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithEmailUserAndRememberMe(LoginTest.java:740)
...

Report flaky test

@jonkoops
jonkoops merged commit 3301195 into keycloak:release/26.0 Dec 10, 2024
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
edewit pushed a commit to edewit/keycloak that referenced this pull request Dec 11, 2024
@rmartinc @edewit
Revert back submitRequest to submit for saml ftl (keycloak#35659)
97a86cf 
Closes keycloak#35488

Signed-off-by: rmartinc <rmartinc@redhat.com>
(cherry picked from commit e488f34)
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
This was referenced Mar 31, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmartinc @jonkoops
0