Repository navigation
Revert back submitRequest to submit for saml ftl - #35584
Merged
Merged
Conversation
Closes keycloak#35488 Signed-off-by: rmartinc <rmartinc@redhat.com>
jonkoops
approved these changes
Dec 4, 2024
mposolda
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35488
Reverting the
submitRequesttosubmitin thesaml-post-form.ftltemplate used for the SAML post binding. It was OK but triggered some issues in the old RH-SSO adapters tests because they are using an oldhtmlunitwhich does not implement that method. As the initial issue #33071 was not related to saml we can revert for the moment only this call.