8000 BACKPORT: Events tab on client and user by edewit · Pull Request #35512 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

BACKPORT: Events tab on client and user - #35512

Merged
edewit merged 3 commits into
keycloak:release/26.0from
edewit:events-tab
Dec 3, 2024
Merged

BACKPORT: Events tab on client and user#35512
edewit merged 3 commits into
keycloak:release/26.0from
edewit:events-tab

Conversation

@edewit
@edewit edewit commented Dec 2, 2024
Copy link
Copy Markdown
Contributor

@edewit
edewit requested a review from a team as a code owner December 2, 2024 14:26
@edewit edewit self-assigned this Dec 2, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Dec 2, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Dec 2, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.ElementClickInterceptedException: 
element click intercepted: Element <input type="submit" class="pf-v5-c-button pf-v5-c-button pf-m-primary btn-lg" id="saveRecoveryAuthnCodesBtn" value="Complete setup" disabled=""> is not clickable at point (1769, 1375). Other element would receive the click: <form action="https://localhost:8543/auth/realms/test/login-actions/required-action?session_code=KL8hqMw4La0NGzjV7jJ5KxH1dpiOVtJBkCVw1S0snfo&amp;execution=CONFIGURE_RECOVERY_AUTHN_CODES&amp;client_id=test-app&amp;tab_id=K7l3Zr0o1Mo&amp;client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIiwic3QiOiJiNDM4MmIwYi1iOTI5LTQzN2UtOWE3Ny02Zjg4Zjg5Y2VhYzIifQ" class="pf-v5-c-form__group" id="kc-recovery-codes-settings-form" method="post">...</form>
  (Session info: chrome=131.0.6778.85)
Build info: version: '4.21.0', revision: '79ed462ef4'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '21.0.5'
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.ass
8000
ertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

antikalk and others added 3 commits December 3, 2024 07:20
@antikalk @edewit
[issue-33569] Show User Events on dedicated tab on Client-/User-Detai…
bd909fa 
…ls (keycloak#33574)

Fixes keycloak#33569

Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit
use user and client from form when on the events section (keycloak#35098
f39d9c6 
)

fixes: keycloak#35048

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit
Remove columns and un-clearable filters (keycloak#34735)
458b955 
fixes: keycloak#34734

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit
edewit merged commit a23ac5e into keycloak:release/26.0 Dec 3, 2024
@edewit
edewit deleted the events-tab branch December 3, 2024 10:06
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
edewit added a commit to edewit/keycloak that referenced this pull request Dec 11, 2024
@edewit @antikalk
BACKPORT: Events tab on client and user (keycloak#35512)
a290543 
* [issue-33569] Show User Events on dedicated tab on Client-/User-Details (keycloak#33574)

Fixes keycloak#33569

Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* use user and client from form when on the events section (keycloak#35098)

fixes: keycloak#35048

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* Remove columns and un-clearable filters (keycloak#34735)

fixes: keycloak#34734

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Co-authored-by: Oliver <antikalk@users.noreply.github.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@agagancarczyk agagancarczyk agagancarczyk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edewit @agagancarczyk @antikalk
0