Repository navigation
Show User Events on dedicated tab on Client-/User-Details - #33574
Merged
Merged
Conversation
antikalk
commented
Oct 4, 2024
Contributor
Author
There was a problem hiding this comment.
These Props are new, to pass a user and/or client to filter on. The props will further be used to initialize the search form and the default value of the form. If a value is present the form input and search will be prefilled and the input for the corresponding property be disabled. Additionally the corresponding Chip will be rendered as non-closeable.
antikalk
commented
Oct 4, 2024
Contributor
Author
There was a problem hiding this comment.
Disable input if a client has been passed to the component.
antikalk
commented
Oct 4, 2024
Contributor
Author
There was a problem hiding this comment.
Disable input if a user has been passed to the component.
antikalk
commented
Oct 4, 2024
Contributor
Author
There was a problem hiding this comment.
Disable close button for user and/or client Chip if a value has been passed to the component. This shall prevent the user from removing the filter on a user or client details screen.
antikalk
commented
Oct 4, 2024
Contributor
Author
There was a problem hiding this comment.
Moved to dedicated UserEvents component.
Fixes keycloak#33569 Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com>
agagancarczyk
approved these changes
Oct 22, 2024
edewit
pushed a commit
to edewit/keycloak
that referenced
this pull request
Dec 3, 2024
…ls (keycloak#33574) Fixes keycloak#33569 Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit
added a commit
that referenced
this pull request
Dec 3, 2024
* [issue-33569] Show User Events on dedicated tab on Client-/User-Details (#33574) Fixes #33569 Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * use user and client from form when on the events section (#35098) fixes: #35048 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * Remove columns and un-clearable filters (#34735) fixes: #34734 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Co-authored-by: Oliver <antikalk@users.noreply.github.com>
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Dec 11, 2024
* [issue-33569] Show User Events on dedicated tab on Client-/User-Details (keycloak#33574) Fixes keycloak#33569 Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * use user and client from form when on the events section (keycloak#35098) fixes: keycloak#35048 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * Remove columns and un-clearable filters (keycloak#34735) fixes: keycloak#34734 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: Oliver Cremerius <antikalk@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Co-authored-by: Oliver <antikalk@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33569
Client Details:
User Details:
Unfortunately I missed the 26.0.0 release :( ... any chance of getting this backported to KC26?
I had to split the UserEvents tab content from the EventsSection in order to reuse it for the client/user details tab.