8000 Allow Keycloak JS to be initialized without passing options (#33950) by jonkoops · Pull Request #33962 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Allow Keycloak JS to be initialized without passing options (#33950) - #33962

Merged
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-33950-26.0
Oct 15, 2024
Merged

Allow Keycloak JS to be initialized without passing options (#33950)#33962
jonkoops merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-33950-26.0

Conversation

@jonkoops
@jonkoops jonkoops commented Oct 15, 2024
Copy link
Copy Markdown
Contributor

Closes #8935

Signed-off-by: Jon Koops jonkoops@gmail.com
(cherry picked from commit 228c21a)

@jonkoops
Allow Keycloak JS to be initialized without passing options (keycloak…
25d8bce 
…#33950)

Closes keycloak#8935

Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 228c21a)
@jonkoops
jonkoops requested review from a team as code owners October 15, 2024 15:47
@jonkoops
jonkoops enabled auto-merge (squash) October 15, 2024 15:47
@jonkoops
jonkoops merged commit 253ca1d into keycloak:release/26.0 Oct 15, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 15, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 15, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserAuthenticationNoneEncryptionSSL

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

jakarta.ws.rs.BadRequestException: HTTP 400 Bad Request
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:236)
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.extractResult(ClientInvocation.java:216)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.BodyEntityExtractor.extractEntity(BodyEntityExtractor.java:59)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

@jonkoops
jonkoops deleted the backport-33950-26.0 branch October 16, 2024 08:09
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes
@rmartinc rmartinc rmartinc approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkoops @ssilvert @rmartinc
0