8000 Allow Keycloak JS to be initialized without passing options by jonkoops · Pull Request #33950 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Allow Keycloak JS to be initialized without passing options - #33950

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
jonkoops:kjs-allow-default-init
Oct 15, 2024
Merged

Allow Keycloak JS to be initialized without passing options#33950
jonkoops merged 1 commit into
keycloak:mainfrom
jonkoops:kjs-allow-default-init

Conversation

@jonkoops
@jonkoops jonkoops commented Oct 15, 2024
Copy link
Copy Markdown
Contributor

Allows the init() method to be called without providing any options, defaulting to an empty object instead. This allows the removal of some conditional code and aligns it with the documentation, which omits the options in several instances.

Closes #8935

@jonkoops
Allow Keycloak JS to be initialized without passing options
ef7c017 
Closes keycloak#8935

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops
jonkoops requested review from a team as code owners October 15, 2024 12:14
@jonkoops
jonkoops commented Oct 15, 2024
Copy link
Copy Markdown
Contributor Author

I recommended reviewing this PR with white-space hidden, as otherwise the diff can be a bit overwhelming. Not much logic has changed, but some indentation has.
image

rmartinc
rmartinc approved these changes Oct 15, 2024
View reviewed changes
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonkoops
jonkoops merged commit 228c21a into keycloak:main Oct 15, 2024
@jonkoops
jonkoops deleted the kjs-allow-default-init branch October 15, 2024 15:46
jonkoops added a commit to jonkoops/keycloak that referenced this pull request Oct 15, 2024
@jonkoops
Allow Keycloak JS to be initialized without passing options (keycloak…
25d8bce 
…#33950)

Closes keycloak#8935

Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 228c21a)
jonkoops added a commit that referenced this pull request Oct 15, 2024
@jonkoops
Allow Keycloak JS to be initialized without passing options (#33950) (#…
253ca1d 
…33962)

Closes #8935

Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 228c21a)
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes
@rmartinc rmartinc rmartinc approved these changes

Assignees

No one assigned

Labels

team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

keycloak.js example from the documentation leads to error path

3 participants

@jonkoops @ssilvert @rmartinc
0