8000 BACKPORT: reset error so when doing a new request, error could be gone (#32974) by edewit · Pull Request #33591 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

BACKPORT: reset error so when doing a new request, error could be gone (#32974) - #33591

Merged
agagancarczyk merged 2 commits into
keycloak:release/26.0from
edewit:backport-32974-26.0
Oct 8, 2024
Merged

BACKPORT: reset error so when doing a new request, error could be gone (#32974)#33591
agagancarczyk merged 2 commits into
keycloak:release/26.0from
edewit:backport-32974-26.0

Conversation

@edewit
@edewit edewit commented Oct 4, 2024
Copy link
Copy Markdown
Contributor

fixes: #32847
backport: #32974

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com
(cherry picked from commit 57dc5a1)

@edewit
reset error so when doing a new request, error could be gone (keycloa…
799effa 
…k#32974)

fixes: keycloak#32847

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 57dc5a1)
@edewit
edewit requested a review from a team as a code owner October 4, 2024 12:54
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Oct 4, 2024
Closed
agagancarczyk
agagancarczyk approved these changes Oct 8, 2024
View reviewed changes
@agagancarczyk agagancarczyk left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agagancarczyk
agagancarczyk enabled auto-merge (squash) October 8, 2024 12:36
@agagancarczyk
agagancarczyk merged commit 5c5c999 into keycloak:release/26.0 Oct 8, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 8, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 8, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@agagancarczyk agagancarczyk agagancarczyk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@agagancarczyk agagancarczyk

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edewit @agagancarczyk
0