8000 reset error on new fetch it could be resolved by edewit · Pull Request #32974 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

reset error on new fetch it could be resolved - #32974

Merged
edewit merged 1 commit into
keycloak:mainfrom
edewit:issue-32847
Oct 4, 2024
Merged

reset error on new fetch it could be resolved#32974
edewit merged 1 commit into
keycloak:mainfrom
edewit:issue-32847

Conversation

@edewit
@edewit edewit commented Sep 16, 2024 •
edited by pedroigor
Loading
Copy link
Copy Markdown
Contributor

reset error so when doing a new request, error could be gone

fixes: #32847
fixes: #31638

@edewit
edewit requested a review from a team as a code owner September 16, 2024 08:25
@edewit edewit self-assigned this Sep 16, 2024
This was referenced Sep 16, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 16, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Sep 16, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=0bc2fd82-8f48-459f-939a-e192e43c8a44&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.url.HostnameV2Test#testInvalidHostnameUrl

Keycloak CI - Base IT (6)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.MultipleTabsLoginTest#expiredAuthenticationAction_currentCodeExpiredExecution

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=976671cd-6c80-48bf-819a-22bc201687b3&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

jonkoops
jonkoops reviewed Sep 16, 2024
View reviewed changes
Comment thread js/libs/ui-shared/src/utils/useFetch.ts Resolved
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 16, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Sep 16, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyNotRequiredNoRK

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=34c51193-5121-44d1-bbce-0db5b93b839b&session_state=d64e350a-65c7-4d89-a62c-2cb7b69b2927&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=b2e0c4c6-2a17-4104-a766-8a312e7e0e43.d64e350a-65c7-4d89-a62c-2cb7b69b2927.2ae3c79c-544e-4898-8a98-f4105010e347)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

@edewit
reset error so when doing a new request, error could be gone
d6525dc 
fixes: keycloak#32847
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@pedroigor pedroigor mentioned this pull request Oct 4, 2024
Closed
@edewit
edewit merged commit 57dc5a1 into keycloak:main Oct 4, 2024
edewit added a commit to edewit/keycloak that referenced this pull request Oct 4, 2024
@edewit
reset error so when doing a new request, error could be gone (keycloa…
dc12d26 
…k#32974)

fixes: keycloak#32847

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 57dc5a1)
@edewit edewit mentioned this pull request Oct 4, 2024
Merged
edewit added a commit to edewit/keycloak that referenced this pull request Oct 4, 2024
@edewit
reset error so when doing a new request, error could be gone (keycloa…
799effa 
…k#32974)

fixes: keycloak#32847

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 57dc5a1)
@edewit edewit mentioned this pull request Oct 4, 2024
Merged
@edewit
edewit deleted the issue-32847 branch October 7, 2024 06:25
agagancarczyk pushed a commit that referenced this pull request Oct 8, 2024
@edewit
reset error so when doing a new request, error could be gone (#32974) (…
c559a3e 
…#33590)

fixes: #32847

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 57dc5a1)
agagancarczyk added a commit that referenced this pull request Oct 8, 2024
@edewit @agagancarczyk
reset error so when doing a new request, error could be gone (#32974) (…
5c5c999 
…#33591)

fixes: #32847

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
(cherry picked from commit 57dc5a1)

Co-authored-by: Agnieszka Gancarczyk <4890675+agagancarczyk@users.noreply.github.com>
@agagancarczyk agagancarczyk mentioned this pull request Oct 16, 2024
Closed
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes
@pedroigor pedroigor pedroigor approved these changes
+3 more reviewers
@jonkoops jonkoops jonkoops left review comments
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@sguilhen sguilhen sguilhen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Admin UI defaults to master realm even without permissions to it Error when non-admin user accesses admin console

5 participants

@edewit @sguilhen @ssilvert @jonkoops @pedroigor
0