8000 All the dist configurations to the new structure by andreaTP · Pull Request #12435 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

All the dist configurations to the new structure - #12435

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
andreaTP:cleanup-all-new-config-3
Jun 17, 2022
Merged

All the dist configurations to the new structure#12435
pedroigor merged 1 commit into
keycloak:mainfrom
andreaTP:cleanup-all-new-config-3

Conversation

@andreaTP
@andreaTP andreaTP commented Jun 9, 2022
Copy link
Copy Markdown
Contributor

Resolves: #12084

@andreaTP
andreaTP requested review from DGuhr, pedroigor and vmuzikar June 9, 2022 10:00
andreaTP
andreaTP commented Jun 9, 2022
View reviewed changes
Comment thread quarkus/rebuild.sh Resolved
pedroigor
pedroigor reviewed Jun 10, 2022
View reviewed changes
@pedroigor pedroigor left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreaTP I have added some comments around changes that seem unrelated to the scope of the PR. Could you please check those and other places where the same comments might apply?

Comment thread config-api/src/main/java/org/keycloak/config/VaultOptions.java Resolved
Comment thread quarkus/rebuild.sh Resolved
Comment thread ...me/src/main/java/org/keycloak/quarkus/runtime/configuration/mappers/HttpPropertyMappers.java Resolved
Comment thread ...src/main/java/org/keycloak/quarkus/runtime/configuration/mappers/LoggingPropertyMappers.java Resolved
@andreaTP
andreaTP force-pushed the cleanup-all-new-config-3 branch from b94abe7 to 4486bc7 Compare June 14, 2022 10:01
@DGuhr DGuhr mentioned this pull request Jun 15, 2022
Merged
@andreaTP @pedroigor
Move all dist options to the new module
ed94519 
Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
@andreaTP
andreaTP force-pushed the cleanup-all-new-config-3 branch from f5de9c7 to ed94519 Compare June 17, 2022 09:43
@andreaTP
andreaTP commented Jun 17, 2022
Copy link
Copy Markdown
Contributor Author

Given a green CI and @pedroigor 's help, I squashed the commits as I believe this PR is ready for final review.

cc. @vmuzikar @DGuhr

@vmuzikar
vmuzikar commented Jun 17, 2022
Copy link
Copy Markdown
Contributor

@andreaTP Thanks, will do the (final) review today.

@pedroigor
pedroigor merged commit 3abcc69 into keycloak:main Jun 17, 2022
@vmuzikar vmuzikar mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes
@vmuzikar vmuzikar Awaiting requested review from vmuzikar
+1 more reviewer
@DGuhr DGuhr DGuhr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move all the distribution option to the new structure

4 participants

@andreaTP @vmuzikar @pedroigor @DGuhr
0