Repository navigation
JPA spi example added - #11110
JPA spi example added#11110
Conversation
|
@stianst what do you expect here? Should I rebuild the PR and add the extension into database guide or do you wait for a review of @DGuhr / @pedroigor? |
|
@psytester if you update the PR to add a section to https://github.com/keycloak/keycloak/blob/main/docs/guides/src/main/server/db.adoc instead of the provider config guide that'd be great. |
|
@psytester Thanks. Can you please update the database guide as suggested by Stian? I'm also wondering if it makes sense to provide some configuration options instead of using the SPI configuration? Not sure because of the upcoming changes to storage though. |
There was a problem hiding this comment.
- I also think the right place would be a
setting the migration strategy for JPAsection in the db guide instead. - I also think it makes sense to have the config exposed in a more convenient way, e.g.
db-migration-strategy, but i would suggest to handle this as a follow up. Created #11678 to discuss this further
|
Change is done. Which magic does add the chapter "Relevant options" to the page to show config parameter and they possible values in a table? https://www.keycloak.org/server/db |
Added: how to configure JPA migration
moved JPA config to db.adoc
|
@psytester Sorry for reaching back late. The magic is in the first lines: but this magic does not work for SPI-settings so-far, as they are not wrapped in the new configuration layer (it only works for configuration we have a mapper for, and as the SPIs are loaded differently (not "wrapped" by this layer), they can't be rendered in the section atm. That said, there's #11678 to change this, but I have not gotten an answer there so-far from the store team and at the moment we are restructuring the config into its own package in #12435 so I hesitate to change sth before this is done. @pedroigor this opens up a kind-of interesting question, that is, can and should we include the spi options into the docs "relevant options" table another way? Apart from that i'll also approve here for now, as it should help ppl nevertheless :) thanks. |
|
@stianst The example is now wrong after the new store integration. The options should use |
Was my first thought too |
Added: how to configure spi for JPA migration settings
Closes discussions #11099 as found solution in issue #10871