Repository navigation
Build operator dependencies first before testing it - #11642
Conversation
|
Hi @ahus1 ! And thanks a lot for opening this issue and proposing a fix! Other than explicitly building the mvn -P operator -pl operator -am clean verify \
....This way we do not need to track dependencies in the future. |
29e0158 to
cc665b9
Compare
|
@andreaTP - I wasn't sure how much time test tests of keycloak-common would take; testing it locally it is 1 sec. Looking at that result, your solution is a lot more robust. I pushed a change, let's see how the builds run with that change. I'll ask you for a review once the build completed. |
|
@andreaTP - the builds are all-green (except the quickstarts). Ready for a review! |
There was a problem hiding this comment.
LGTM after removing the old implementation of it 🙂
Thanks a ton!
cc665b9 to
7cba86c
Compare
|
Thanks again @ahus1 LGTM! |
|
@andreaTP - I see that the other PR is touch quite some bits and pieces, and I would need to build it locally to see if it tackes the same issues. Once that other PR has been merged, I'm happy to check if this PR is still necessary and will then either rebase or close it. |
Closes #11641