8000 Handle current time in seconds as long by ahus1 · Pull Request #11611 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Handle current time in seconds as long - #11611

Closed
ahus1 wants to merge 1 commit into
keycloak:mainfrom
ahus1:is-11053-handle-time-in-seconds-as-long
Closed

Handle current time in seconds as long#11611
ahus1 wants to merge 1 commit into
keycloak:mainfrom
ahus1:is-11053-handle-time-in-seconds-as-long

Conversation

@ahus1
@ahus1 ahus1 commented Apr 22, 2022
Copy link
Copy Markdown
Member

This avoids the overflow of the integer in 2038. Old getXXX methods remain for now as they provide null-safe access to the values.

Closes #11053

@ahus1 ahus1 added this to the 19.0.0 milestone Apr 22, 2022
@ahus1 ahus1 added kind/enhancement Categorizes a PR related to an enhancement area/core Core server — startup, configuration, providers/SPIs, cross-cutting concerns labels Apr 22, 2022
@ahus1
ahus1 force-pushed the is-11053-handle-time-in-seconds-as-long branch from 6a78a8c to ea1e3e0 Compare April 22, 2022 16:12
@ahus1 ahus1 added the area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching label Apr 22, 2022
@ahus1
ahus1 commented Apr 22, 2022
Copy link
Copy Markdown
Member Author

@hmlnarik / @stianst - I've prepared this (draft) PR to handle seconds as long.

After the change I was able to start Keycloak locally and log in. Test on CI are still running.

I'd be happy if you could comment if this PR is going into the right direction. There are also 4 DB columns that will be enhanced from INT to BIGINT.

@ahus1
Handle current time in seconds as long
a4f957a 
This avoids the overflow of the integer in 2038. Old getXXX methods remain for now as they provide null-safe access to the values.

Closes keycloak#11053
@ahus1
ahus1 force-pushed the is-11053-handle-time-in-seconds-as-long branch from ea1e3e0 to a4f957a Compare April 25, 2022 06:59
@ahus1
ahus1 marked this pull request as ready for review April 25, 2022 08:22
@ahus1
ahus1 commented Apr 25, 2022
8000
Copy link
Copy Markdown
Member Author

This is now ready for review. I reviewed the Cross-DC-Tests, and they seem to be unstable. I didn't find a related exception, only some Infinispan locking exceptions. The operator fails due to #11642 and builds locally just fine.

There are some changes in AuthenticationSessionEntity.java where I add a new serialization version as the old contained a Integer, and the new contains a Long. A short feedback if that was really necessary would be nice.

@hmlnarik hmlnarik removed this from the 19.0.0 milestone Apr 25, 2022
@ahus1
ahus1 commented Apr 25, 2022
Copy link
Copy Markdown
Member Author

Closing this PR as priorities are with the new store.

@ahus1 ahus1 closed this Apr 25, 2022
@tsaarni
tsaarni commented Mar 22, 2024
Copy link
Copy Markdown
Contributor

Would this PR be valid now again (if rebased) as the new storage got dropped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ahus1 ahus1

@hmlnarik hmlnarik

Labels

area/core Core server — startup, configuration, providers/SPIs, cross-cutting concerns area/storage Storage layer — JPA entities, database schemas, Liquibase migrations, caching kind/enhancement Categorizes a PR related to an enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support 2038 timestamps in Keycloak (Epochalypse)

3 participants

@ahus1 @tsaarni @hmlnarik
0