8000 Don't enable kubelet until after kubeadm generates config by priyawadhwa · Pull Request #9111 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Don't enable kubelet until after kubeadm generates config - #9111

Merged
tstromberg merged 2 commits into
kubernetes:masterfrom
priyawadhwa:fix-kubelet
Aug 28, 2020
Merged

tstromberg merged 2 commits into
kubernetes:masterfrom
priyawadhwa:fix-kubelet

Conversation

@priyawadhwa
@priyawadhwa priyawadhwa commented Aug 28, 2020 •
Copy link
Copy Markdown

As written in the k8s 1.19 CHANGELOG:

Kubeadm: Move the "kubeadm init" phase "kubelet-start" later in the init workflow, after the "kubeconfig" phase. This makes kubeadm start the kubelet only after the KubeletConfiguration component config file (/var/lib/kubelet/config.yaml) is generated and solves a problem where init systems like OpenRC cannot crashloop the kubelet service. (#90892, @xphoniex) [SIG Cluster Lifecycle]

Starting kubelet before the config exists caused up to 3x longer start time with 1.19. This PR removes the call to start kubelet before kubeadm init, and also puts the kubeadm phases in the correct order.

fixes #9106

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2020
@priyawadhwa
Copy link
Copy Markdown
Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 28, 2020
@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9111): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9111/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9111/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9111): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9111/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9111/minikube: exec format error

@tstromberg
tstromberg merged commit c25a2e6 into kubernetes:master Aug 28, 2020
@priyawadhwa
priyawadhwa deleted the fix-kubelet branch August 28, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kubernetes v1.19.0 starts up 3X slower than v1.18 on macOS

4 participants

0