Repository navigation
Update DefaultKubernetesVersion to v1.19.0 - #9050
Conversation
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 6939b560-e3ef-11ea-ae1e-a7d25f4a9615 |
|
kvm2 Driver |
Travis tests have failedHey @tstromberg, 1st Buildmake testTravisBuddy Request Identifier: 9397d980-e3f0-11ea-ae1e-a7d25f4a9615 |
|
Initial docker failures:
initial none failures:
I'll try running the test locally to see if I can get to the bottom of the ComponentHealth failure. The rest I'm not too worried about. |
|
The integration test definitely found something strange: However: |
|
kvm2 Driver Times for Minikube (PR 9050): 73.9s 63.8s 64.0s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9050): 30.7s 28.4s 29.9s Averages Time Per Log Details |
|
I can confirm that MultiNode works both for docker & virtualbox locally: docker: virtualbox: |
|
kvm2 Driver Times for Minikube (PR 9050): 65.3s 65.1s 64.2s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9050): 29.0s 29.0s 28.9s Averages Time Per Log Details |
|
kvm2 Driver Times for Minikube (PR 9050): 62.7s 64.4s 66.8s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9050): 29.7s 27.7s 31.7s Averages Time Per Log Details |
|
kvm2 Driver Times for Minikube (PR 9050): 66.1s 65.5s 63.9s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9050): 28.6s 29.9s 29.2s Averages Time Per Log Details |
|
/ok-to-test |
|
NOTE: I'm seeing a ~3X startup performance regression on macOS (Docker), that I'm not seeing in CI. |
|
Perf regression appears to be fixed by #9111 |
|
kvm2 Driver Times for Minikube (PR 9050): 80.0s 66.8s 64.4s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9050): 31.3s 39.7s 28.4s Averages Time Per Log Details |
Travis tests have failedHey @tstromberg, 1st Buildmake test2nd Buildmake test3rd BuildmakeTravisBuddy Request Identifier: 96d6bd20-e95c-11ea-ae3c-2d16223a9f65 |
|
kvm2 Driver Times for Minikube (PR 9050): 65.9s 65.1s 65.8s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9050): 28.2s 30.7s 30.0s Averages Time Per Log Details |
This reverts commit 5bbfc3c.
|
kvm2 Driver Times for Minikube (PR 9050): 70.7s 67.3s 65.0s Averages Time Per Log Detailsdocker Driver Times for Minikube (PR 9050): 28.7s 28.5s 28.6s Averages Time Per Log Details |
|
Please take a look - the integration tests flakes now appear to all be unrelated to this PR. |
|
/ok-to-test |
So that we have time to soak in failing integration tests before v1.19.0 is released on Tuesday.