8000 Revert "docker-env: fall back to bash if can not detect shell." by medyagh · Pull Request #7894 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Revert "docker-env: fall back to bash if can not detect shell." - #7894

Merged
medyagh merged 1 commit into
masterfrom
revert-7887-bash_fallback_docker_env
Apr 24, 2020
Merged

medyagh merged 1 commit into
masterfrom
revert-7887-bash_fallback_docker_env

Conversation

@medyagh
@medyagh medyagh commented Apr 24, 2020 •
Copy link
Copy Markdown
Member

this PR's build fails on windows

cmd/minikube/cmd/docker-env.go:174:15: undefined: "github.com/docker/machine/libmachine/shell".ErrUnknownShell
make: *** [Makefile:186: out/minikube-windows-amd64] Error 2
Makefile:184: recipe for target 'out/minikube-windows-amd64' failed
make: *** [out/minikube-windows-amd64] Error 2
make: *** Waiting for unfinished jobs....
+ failed=2
++ go env GOOS

Reverts #7887

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2020
@medyagh
medyagh merged commit bc0d773 into master Apr 24, 2020
@afbjorklund
Copy link
Copy Markdown
Collaborator

The libmachine shell code is confusing, the unix code is called "shell.go" (and not shell_unix.go)

@medyagh
medyagh deleted the revert-7887-bash_fallback_docker_env branch May 2, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0