8000 docker-env: fall back to bash if can not detect shell. by medyagh · Pull Request #7887 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

docker-env: fall back to bash if can not detect shell. - #7887

Merged
medyagh merged 1 commit into
kubernetes:masterfrom
medyagh:bash_fallback_docker_env
Apr 24, 2020
Merged

medyagh merged 1 commit into
kubernetes:masterfrom
medyagh:bash_fallback_docker_env

Conversation

@medyagh
@medyagh medyagh commented Apr 24, 2020 •
Copy link
Copy Markdown
Member

while making a github action bot for minikube, I was trying to use docker-env functionality,
I realized github action shell is NOT detectable, even though it is bash.
because it doesn't give you SHELL environment variable.

I even set shell: bash expclicitly but still minikube cant detect it
https://github.com/k8sguard/discover/blob/master/.github/workflows/main.yml#L17

I think it is better for minikube to fall back to bash instead of crashing and not doing anything. and more users will be able to use minikube in github actions and environments like that.

closes #7886
closes #6766

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2020
@medyagh medyagh changed the title fall back to bash if can not detect docker-env: fall back to bash if can not detect shell. Apr 24, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2020
@medyagh
medyagh commented Apr 24, 2020
Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 24, 2020
@medyagh medyagh changed the title docker-env: fall back to bash if can not detect shell. wip: docker-env: fall back to bash if can not detect shell. Apr 24, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot Apr 24, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot Apr 24, 2020
@medyagh
medyagh commented Apr 24, 2020
Copy link
Copy Markdown
Member Author

/retest-this-please

@minikube-pr-bot
Copy link
Copy Markdown

kvm2 Driver
docker Driver

@medyagh medyagh closed this Apr 24, 2020
@medyagh medyagh reopened this Apr 24, 2020
@medyagh medyagh changed the title wip: docker-env: fall back to bash if can not detect shell. docker-env: fall back to bash if can not detect shell. Apr 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker-env in github actions: X Error detecting shell: Error: Unknown shell Default to bash shell when $SHELL is missing

4 participants

0