Repository navigation
Add JSON output for addons list - #5601
Conversation
|
Hi @woodcockjosh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch? |
|
/assign @medyagh |
f026626 to
b8c3fe4
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woodcockjosh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5601 +/- ##
==========================================
- Coverage 37.45% 36.88% -0.58%
==========================================
Files 103 102 -1
Lines 7540 7399 -141
==========================================
- Hits 2824 2729 -95
+ Misses 4342 4317 -25
+ Partials 374 353 -21
|
5507db0 to
9553c5d
Compare
|
@sharifelgamal thanks for the review! |
|
@minikube-bot OK to test |
9553c5d to
60bd68d
Compare
60bd68d to
1875a62
Compare
1875a62 to
b132b04
Compare
|
/ok-to-test |
Depends on #5555
Before
Command:
Output:
After
Command:
Output:
Output and Format options cannot both be used at the same time
Command:
minikube addons list -o json -f "hello"Output: