Repository navigation
Fix addons list output format option - #5555
Conversation
|
Hi @woodcockjosh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch? |
|
/assign @medyagh |
|
I am not familiar with what this PR is trying to solve, do we have an issue for this ? or was it side effect of a recently merged PR ? |
@medyagh Apparently this feature doesn't work at all. I didn't open an issue because it was trivial to fix. However, there is a question about whether or not it should be implemented seeing as it doesn't work for anyone. Maybe instead we should implement a |
There was a problem hiding this comment.
Looks good. Do you mind adding a small integration test to make sure we don't break this in the future?
minikube/test/integration/functional_test.go
Line 307 in dcde5b6
It's impossible to predict what addons are actually enabled until #4227 is resolved, but you can at least test something like "every line matches ^(en|dis)abled$`.
|
Since this may be your first integration test addition, I thought I'd point you to some useful docs for iterating quickly on integration tests: https://github.com/kubernetes/minikube/blob/master/test/integration/README.md |
|
/ok-to-test |
|
@tstromberg I will have time to try to add a test tomorrow |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woodcockjosh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5555 +/- ##
==========================================
+ Coverage 36.63% 36.93% +0.29%
==========================================
Files 102 102
Lines 7346 7373 +27
==========================================
+ Hits 2691 2723 +32
+ Misses 4298 4297 -1
+ Partials 357 353 -4
|
|
@medyagh this is complete |
|
/retest |
|
@minikube-bot OK to test |
|
Thank you! |
Fixes option to set the output format for listing addons