8000 Fix Userlists: Don't overwrite page parameter by Vernoxvernax · Pull Request #453 · jikan-me/jikan-rest · GitHub
[go: up one dir, main page]

Skip to content

Fix Userlists: Don't overwrite page parameter - #453

Merged
irfan-dahir merged 3 commits into
jikan-me:masterfrom
Vernoxvernax:master
Oct 28, 2023
Merged

irfan-dahir merged 3 commits into
jikan-me:masterfrom
Vernoxvernax:master

Conversation

@Vernoxvernax
Copy link
Copy Markdown
Contributor

This pull-request depends on #452.

The array from line 20 specifically excludes page among other keys.
Additionally, the constructor of both UserAnimeListRequest and UserMangaListRequest already specify optional values for page.
In the return line, the correct page key has previously been overwritten using the values from the values array, or at least that's what I think.
It works for me, but please test before merging.

line 20 specifically excludes "page" among other keys
@Vernoxvernax
Vernoxvernax requested a review from a team as a code owner October 27, 2023 03:30
@irfan-dahir
irfan-dahir requested a review from pushrbx October 27, 2023 04:48
@irfan-dahir
irfan-dahir merged commit b4f4135 into jikan-me:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0