8000 container-setup.sh: Fix binary checks in validate_prereqs. by Vernoxvernax · Pull Request #450 · jikan-me/jikan-rest · GitHub
[go: up one dir, main page]

Skip to content

container-setup.sh: Fix binary checks in validate_prereqs. - #450

Merged
pushrbx merged 1 commit into
jikan-me:masterfrom
Vernoxvernax:master
Oct 26, 2023
Merged

pushrbx merged 1 commit into
jikan-me:masterfrom
Vernoxvernax:master

Conversation

@Vernoxvernax
Copy link
Copy Markdown
Contributor

I'm still a little confused by how the checks are done.
Like, -n in line 60, instead of -x, like for the rest of the checks.
These changes make it at least possible for me to create the containers.

first check whether docker or podman bins are there; then choose one one of them
@Vernoxvernax
Vernoxvernax requested a review from a team as a code owner October 26, 2023 17:09
@pushrbx
pushrbx commented Oct 26, 2023 •
Copy link
Copy Markdown
Collaborator

It worked for me because I have podman installed. 🤦‍♂️ Thanks for this!

Also on line 60 it should be -x too. Will change it later.

@pushrbx
pushrbx merged commit 1be19fc into jikan-me:master Oct 26, 2023
Vernoxvernax added a commit to Vernoxvernax/jikan-rest that referenced this pull request Oct 27, 2023
Merge pull request jikan-me#450 from Vernoxvernax/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0