8000 Report short TypeScript comments by zerone0x · Pull Request #198 · habit-hooks/habit-hooks · GitHub
[go: up one dir, main page]

Skip to content

Report short TypeScript comments - #198

Merged
devill merged 1 commit into
habit-hooks:mainfrom
zerone0x:fix-ts-comment-short-threshold
Oct 2, 2026
Merged

devill merged 1 commit into
habit-hooks:mainfrom
zerone0x:fix-ts-comment-short-threshold

Conversation

@zerone0x
Copy link
Copy Markdown
Contributor

Summary

  • remove the minimum-length gates from the TypeScript non-essential-comment sensor
  • add coverage proving short // note and /* why */ comments are still reported

Fixes #181.

Tests

  • pnpm install --frozen-lockfile
  • uv run pytest plugins/typescript/tests/test_the_comment_helper_finds_ts_morph.py plugins/typescript/tests/test_node_sensors_ignore_the_project_manifest.py::test_vendored_comment_helper_reports_a_comment
  • uv run ruff check plugins/typescript/tests/test_the_comment_helper_finds_ts_morph.py
  • uv run pytest plugins/typescript/tests

@devill
devill merged commit 5603331 into habit-hooks:main Oct 2, 2026
3 checks passed
@devill
devill commented Oct 2, 2026
Copy link
Copy Markdown
Collaborator

Thansk for the PR! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove lower limit from non-essential-comment sensors

2 participants

0