Repository navigation
checkstyle: add 14.3.0 - #906
Conversation
JVM tool for the Java loadout (#899): upstream release artifact run on our jdk through a /usr/bin wrapper, with Standalone tests that run the tool on a small real input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 15 minutes for your next included review. View limit details
Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Clean. The sha256 matches, LGPL-2.1-or-later is correct, and the tests cover both google_checks.xml (warning) and sun_checks.xml (error).
Holding approval only on the shared JVM prebuilt-jar policy question, which is being decided once for the batch.
Generated by Claude Code
|
Thanks @norrietaylor.
🤖 Generated with Claude Code |
There was a problem hiding this comment.
Approving under #970. The install -m 0644 nit is fixed and the branch is past #897. Please merge after #970.
Generated by Claude Code
What
Adds
checkstyle14.3.0, the Java style and convention linter. It is a Tier 1 item in the #899 Java loadout checklist.checkstyle-14.3.0-all.jarfrom GitHub releases (checkstyle plus its dependencies, withMain-Classset). It is installed atusr/share/checkstyle/checkstyle.jarand run on ourjdkthrough a/usr/bin/checkstylewrapper (exec java -jar …).google_checks.xmlandsun_checks.xmlare bundled as classpath resources, socheckstyle -c /google_checks.xml File.javaworks with no extra files. 14.x targets Java 21 (class file version 65); ourjdkis 25 (Temurin, since jdk: current LTS (meta over jdk-25); add jdk-25 (Temurin 25) and jdk-21 (Temurin 21) #897), which satisfies it.maven,gradleandjdtlsmake. Recorded asbinary_from.LGPL-2.1-or-later. The source headers say "either version 2.1 of the License, or (at your option) any later version". It is copyleft, so the corresponding-source report will want this jar's sources on the mirror like any LGPL package.source_provenance = GithubRepo checkstyle/checkstyle. Tags arecheckstyle-<version>, which pkgmgr strips as a package-name prefix.754e218a…ee749b2, computed locally and matching the GitHub release asset digest.Tests (Standalone)
google_checks: aclass bad_name {}file must produce a[WARN] … [TypeName]finding. A conforming file must report no[WARN]. The conforming file isdemo/Good.javawithpackage demo;, becausePackageDeclarationis in the Google set.exit_code:sun_checks.xmluses severityerror, and checkstyle exits with the error count, so the same bad file must fail the run with an[ERROR] … [TypeName]line.Verified
Built in a
pkgbuildsession (arm64).min check --packages checkstylepassed every checker, includingstandalone tests. The first draft of the test had a "clean" file with no package declaration, and it correctly failed on thePackageDeclarationwarning. That is the negative control.amd64 is not separately run locally; it is left to CI.
Refs #899
🤖 Generated with Claude Code