Repository navigation
ruby: drop the bundled gems' mkmf.log and gem_make.out (build logs with random temp names) - #875
Conversation
… names made every build differ) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 57 minutes for your next included review. View limit details
Comment |
|
Verified on the lab box: two forced builds of ruby with this recipe laid over pkgs c930e31, in separate fresh caches, produced identical trees (0 of 2919 files differ). Before the change the same double build differed in exactly one file, mkmf.log. |
There was a problem hiding this comment.
LGTM. It's the same cleanup as packages/ruby-lsp/build.sh:24. RubyGems checks gem.build_complete, not these logs, so nothing breaks. The double build shows 0 of 2919 files differing.
Generated by Claude Code
…in's trust store and build cleanup - chromedriver-bin: 155.0.8059.39 -> 155.0.8059.84, matching main's chromium-headless-shell-bin (#894). The version is no longer a literal: it is chromium-headless-shell-bin.attrs.upstream_version, the same shape as glibc-locale-c-utf8 and rust-arm-embedded. A browser bump now changes the driver's URLs, so the driver's build fails on its sha256s until they move in the same change, instead of shipping a driver that refuses the browser. matches_browser therefore checks the driver binary, the browser binary and the browser package's declared version against each other. CfT zips: linux64 4fe24330..., linux-arm64 738853f0...; both downloads' MD5s match the GCS object x-goog-hash, and both binaries carry the 155.0.8059.84 version string and the BSD-3-Clause LICENSE.chromedriver. - ruby-3.2/3.3/3.4: the drop-in siblings of `ruby` take what main gave it. From #957: ca-certificates in runtime_deps (after glibc) plus the trust_store test, per AGENTS.md "Declare the store when you read it". From #875: delete mkmf.log / gem_make.out after install, since they record gcc's random temp names and break reproducibility. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Diffing the published ruby artifacts of two world rebuilds (build-servers early-cutoff study): 1 of 2926 files differed,
usr/lib/ruby/gems/4.0.0/gems/bigdecimal-4.0.1/ext/bigdecimal/mkmf.log, because it records gcc's random/tmp/ccXXXXXX.onames. A same-host double build on the lab box showed the same single file. Everything else in ruby is byte-identical build to build.Deletes
mkmf.logandgem_make.outfrom the output tree after install, the same cleanupruby-lspalready does for its gems. Nothing reads these logs at runtime.🤖 Generated with Claude Code