Repository navigation
AGENTS.md: the checker rejects SOURCE_DATE_EPOCH=0 re-sets, not every re-set - #867
Conversation
It rejects re-setting it to 0, not any re-set; a non-zero override passes, which is how the openjdk rungs (#775) carried one. Point at the per-tool option instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly describes the primary documentation change: the checker rejects re-s 8000 etting SOURCE_DATE_EPOCH to 0, not every re-set. It is specific and related to the pull request, although it does … |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
LGTM. It's consistent with practice on main: microvm-rootfs's ${SOURCE_DATE_EPOCH:-0} passes the check, and openjdk uses --with-source-date instead of re-exporting.
Optional nits:
- "rejects setting either to
0again" slightly overstates it, since only a literal=0is caught. - The caveat about non-zero overrides should cover
PYTHONHASHSEEDtoo.
Generated by Claude Code
AGENTS.md (CLAUDE.md is a symlink to it) says the checker rejects setting
SOURCE_DATE_EPOCHorPYTHONHASHSEEDagain. The rule inminimal/crates/check/src/lib.rsonly matches setting either to0. A non-zero override passes, which is how all 17 openjdk rungs in #775 carriedexport SOURCE_DATE_EPOCH=315532802through minimal-check (found by @norrietaylor's review).This states the rule as it is, and adds the guidance #775 now follows: give a tool that can't use epoch 0 its date through its own option (
--with-source-datefor JDK 15+,SH_DATEfor nspr) rather than re-exporting the variable.Docs only.
🤖 Generated with Claude Code
Summary by CodeRabbit
SOURCE_DATE_EPOCHandPYTHONHASHSEEDto0, and the checker rejects setting them to0again.