8000 chore(stacks)!: rename harnesses to stacks by twitchyliquid64 · Pull Request #250 · gominimal/pkgs · GitHub
[go: up one dir, main page]
Skip to content

chore(stacks)!: rename harnesses to stacks #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twitchyliquid64 merged 1 commit into from
Jun 16, 2026
Merged

chore(stacks)!: rename harnesses to stacks #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion minimal.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[stdlib]
minimum_version = "0.0.11"
minimum_version = "0.0.15"
@coderabbitai coderabbitai Bot Jun 15, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Minimum stdlib version does not match the stated breaking-change requirement.

Line 2 pins minimum_version to 0.0.15, but this PR’s objective says the breaking rename requires 0.4.1+. Keeping 0.0.15 weakens the compatibility gate and may permit unsupported consumers.

Suggested fix 
 [stdlib]
-minimum_version = "0.0.15"
+minimum_version = "0.4.1"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
minimum_version = "0.0.15"
[stdlib]
minimum_version = "0.4.1"
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@minimal.toml` at line 2, The minimum_version value is set to "0.0.15" but the
breaking changes in this PR require at least version "0.4.1" to function
correctly. Update the minimum_version field to "0.4.1" to ensure that only
compatible stdlib versions are allowed to use this code and prevent runtime
failures from unsupported consumers running older versions.


[tasks.shell]
interactive = true
Expand Down
4 changes: 2 additions & 2 deletions harnesses/bun/harness.ncl → stacks/bun/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "bun",
runtime_packages = ["bun"],
build_packages = ["base", "curl"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/cabal/harness.ncl → stacks/cabal/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "cabal",

build_packages = ["ghc", "cabal", "base"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/cmake/harness.ncl → stacks/cmake/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "cmake",

build_packages = ["cmake", "make", "gcc", "binutils", "pkgconf", "linux_headers", "base"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/deno/harness.ncl → stacks/deno/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "deno",
runtime_packages = ["deno"],
build_packages = ["base", "curl"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/go/harness.ncl → stacks/go/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "go",
build_packages = ["go", "binutils", "linux_headers"],
build_cmd = "go build",
Expand Down
4 changes: 2 additions & 2 deletions harnesses/gradle/harness.ncl → stacks/gradle/stack.ncl
View file 8BD0
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "gradle",
build_packages = ["gradle", "jdk", "base", "curl"],
runtime_packages = ["jdk"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/make/harness.ncl → stacks/make/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "make",

build_packages = ["make", "gcc", "binutils", "autoconf", "automake", "libtool", "m4", "pkgconf", "linux_headers", "base"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/maven/harness.ncl → stacks/maven/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "maven",
build_packages = ["maven", "jdk", "base", "curl"],
runtime_packages = ["jdk"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/meson/harness.ncl → stacks/meson/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "meson",

build_packages = ["meson", "ninja", "gcc", "binutils", "pkgconf", "linux_headers", "python", "base"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/npm/harness.ncl → stacks/npm/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "npm",

runtime_packages = ["node-lts"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/pip/harness.ncl → stacks/pip/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "pip",

runtime_packages = ["python"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/pnpm/harness.ncl → stacks/pnpm/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "pnpm",

runtime_packages = ["node-lts"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/pulumi-go/harness.ncl → stacks/pulumi-go/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "pulumi-go",

build_packages = ["go", "binutils", "linux_headers"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/pulumi-nodejs/harness.ncl → stacks/pulumi-nodejs/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "pulumi-nodejs",

runtime_packages = ["pnpm", "pulumi"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/rust/harness.ncl → stacks/rust/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "rust",

build_packages = ["gcc", "rust", "binutils", "pkgconf", "linux_headers"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/shell/harness.ncl → stacks/shell/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "shell",
build_packages = ["base", "curl"],
build_cmd = ["bash", "-c", "echo \"Error: minimal is configured with the fallback shell harness which cannot build\" >&2 && exit 1"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/stack/harness.ncl → stacks/stack/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "stack",

build_packages = ["stack", "ghc", "base"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/uv/harness.ncl → stacks/uv/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "uv",

build_packages = ["uv", "base", "toolchain"],
Expand Down
4 changes: 2 additions & 2 deletions harnesses/zig/harness.ncl → stacks/zig/stack.ncl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { harness, .. } = import "minimal.ncl" in
harness {
let { stack, .. } = import "minimal.ncl" in
stack {
name = "zig",
build_packages = ["zig", "base", "glibc", "linux_headers"],
build_cmd = "zig build -Doptimize=ReleaseSafe",
Expand Down
0