Repository navigation
chore(stacks)!: rename harnesses to stacks - #250
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthrough
Changesharness → stack rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@minimal.toml`:
- Line 2: The minimum_version value is set to "0.0.15" but the breaking changes
in this PR require at least version "0.4.1" to function correctly. Update the
minimum_version field to "0.4.1" to ensure that only compatible stdlib versions
are allowed to use this code and prevent runtime failures from unsupported
consumers running older versions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c2f3aadf-8670-42a7-b9e1-1a13b0b4a4c3
📒 Files selected for processing (20)
minimal.tomlstacks/bun/stack.nclstacks/cabal/stack.nclstacks/cmake/stack.nclstacks/deno/stack.nclstacks/go/stack.nclstacks/gradle/stack.nclstacks/make/stack.nclstacks/maven/stack.nclstacks/meson/stack.nclstacks/npm/stack.nclstacks/pip/stack.nclstacks/pnpm/stack.nclstacks/pulumi-go/stack.nclstacks/pulumi-nodejs/stack.nclstacks/rust/stack.nclstacks/shell/stack.nclstacks/stack/stack.nclstacks/uv/stack.nclstacks/zig/stack.ncl
| @@ -1,5 +1,5 @@ | |||
| [stdlib] | |||
| minimum_version = "0.0.11" | |||
| minimum_version = "0.0.15" | |||
Contributor
There was a problem hiding this comment.
Minimum stdlib version does not match the stated breaking-change requirement.
Line 2 pins minimum_version to 0.0.15, but this PR’s objective says the breaking rename requires 0.4.1+. Keeping 0.0.15 weakens the compatibility gate and may permit unsupported consumers.
Suggested fix
[stdlib]
-minimum_version = "0.0.15"
+minimum_version = "0.4.1"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| minimum_version = "0.0.15" | |
| [stdlib] | |
| minimum_version = "0.4.1" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@minimal.toml` at line 2, The minimum_version value is set to "0.0.15" but the
breaking changes in this PR require at least version "0.4.1" to function
correctly. Update the minimum_version field to "0.4.1" to ensure that only
compatible stdlib versions are allowed to use this code and prevent runtime
failures from unsupported consumers running older versions.
twitchyliquid64
enabled auto-merge
June 15, 2026 22:55
cvince
pushed a commit
to capysc/pkgs
that referenced
this pull request
Oct 2, 2026
…d package (gominimal#643) Report-only sibling to trivial-update.yml (inbox#20's fast-path suite). For each package a PR changes: TRUE LEAF (no recipe imports it, no stack/profile names it — worst case is confined to the package itself), leaf-but-referenced, or direct + transitive dependent counts with the top importers named. Current catalog: 472 packages, 195 true leaves (41%). The two-source edge scan matters: stacks reference packages by NAME (build_packages = ["go", ...]), not by import, so an import-only scan misclassifies every stack tool as a leaf — verified ghidra/deno/lean/ gradle and 11 others are caught only by the name scan. String matching over-demotes, which is the safe direction for a classifier whose consumers may one day fast-path leaf updates. The summary's final line is stable and machine-readable (blast-radius: ALL-TRUE-LEAVES | HAS-DEPENDENTS) so a future auto-merge lane for trivial+leaf bumps can key on it without parsing the table. Composes with gominimal#250's check scoping (a leaf PR now builds and checks only itself) and the dwell/soak gate (auto-merged updates would still soak on main before stable promotion). Pure checkout scan, no network, never a required check. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires minimal
0.4.1, released almost a month agoSummary by CodeRabbit