8000 minimal.toml: name the bash session entry `default` (min 0.8 activate) by bryan-minimal · Pull Request #1617 · gominimal/pkgs · GitHub
[go: up one dir, main page]

Skip to content

minimal.toml: name the bash session entry default (min 0.8 activate) - #1617

Open
bryan-minimal wants to merge 1 commit into
mainfrom
minimal-toml-default-session
Open

bryan-minimal wants to merge 1 commit into
mainfrom
minimal-toml-default-session

Conversation

@bryan-minimal
@bryan-minimal bryan-minimal commented Nov 20, 2026 •
Copy link
Copy Markdown
Member

Fixes #1616.

min 0.8 won't activate a project that declares several session entries when none is named default (NET-060). pkgs has three: shell, claude and opencode. So every local min session activate of pkgs failed.

This PR renames [sessions.shell] to [sessions.default] and leaves its contents unchanged. Activation then gets the plain bash session again. Nothing in pkgs refers to the shell entry by name. claude and opencode are unchanged.

Tested: the four agents behind pkgs#1608–#1615 activated with exactly this rename made locally.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Configuration
    • Renamed the session profile in the minimal configuration from shell to default. The package list and Bash execution command remain unchanged. Update any references to the former profile name when using this configuration.

min 0.8 refuses to activate a project with several session entries and
none named default (NET-060), so every local pkgs activation failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 20, 2026 21:27
@coderabbitai
coderabbitai Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Bash session table in minimal.toml is renamed from sessions.shell to sessions.default. Its package list and Bash execution command remain unchanged.

Changes: Session configuration

Layer / File(s) Summary
Rename the Bash session entry
minimal.toml
The session table name changes from sessions.shell to sessions.default. Its settings are unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • gominimal/pkgs#1373: Moves the shell, claude, and opencode entries to [sessions.*], including the entry renamed here.
  • gominimal/pkgs#1390: Introduces the [sessions.shell] entry that this change renames.

Suggested reviewers: norrietaylor

Merge Risk: Minimal · up to c0559

This renames the Bash session entry to default so min 0.8 can activate the project without a local edit. The change is small and easy to revert, and no merge risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: the bash session entry in minimal.toml is renamed to default, which matches the raw summary and the PR objectives (renaming [sessions.shell] to [sessions.default] so min 0.…
Linked Issues check Passed Directly linked issue #1616 requires renaming [sessions.shell] to [sessions.default] in minimal.toml and keeping its contents. The diff between the merge base and reviewed head shows exactly thi…
Out of Scope Changes check Passed The whole-PR change set consists of one line in minimal.toml: the session table name changes from shell to default. Renaming the entry is the change #1616 requests. No other files are changed in…
Full details: Title check

Explanation

The title names the change: the bash session entry in minimal.toml is renamed to default, which matches the raw summary and the PR objectives (renaming [sessions.shell] to [sessions.default] so min 0.8 can activate projects). It also gives the reason (min 0.8 activation). It is specific, concise, and describes the primary change.

Full details: Linked Issues check

Explanation

Directly linked issue #1616 requires renaming [sessions.shell] to [sessions.default] in minimal.toml and keeping its contents. The diff between the merge base and reviewed head shows exactly this change: -[sessions.shell] / +[sessions.default]. The packages, exec = "bash --noprofile -l" lines are unchanged. The claude and opencode entries are not in the diff, so they remain unchanged, as the issue requires. The issue's requirement is a coding change to the session table, and the code implements it. The claim that activation then selects the plain bash session follows from min 0.8's selection rule as described in the issue; I did not verify min's source. The claim that no pkgs file refers to the shell entry by name was not verified by a repository-wide search, but the issue's requirement does not depend on it.

Full details: Out of Scope Changes check

Explanation

The whole-PR change set consists of one line in minimal.toml: the session table name changes from shell to default. Renaming the entry is the change #1616 requests. No other files are changed in the diff against the merge base. No unrelated change is present.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 03aa958 and c05595d.

Files selected for processing: 1

  • minimal.toml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

@bryan-minimal
Copy link
Copy Markdown
Member Author

I tested this on the PR branch with min 0.8.0-dev.549.ga42a9d6d, using the normal tarball sync:

  • With this change: min session activate . succeeds. The session runs, and claude is on PATH, which shows the default entry's packages were applied. The session was destroyed afterwards.
  • Control (the [sessions.shell] that main has): activation fails before creating anything:

    error: Cannot start the box: the project's minimal.toml declares the session entries claude, opencode, shell. None of them is named "default", so the start cannot pick one. Rename the entry to start to "default" in minimal.toml.

@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope matches the title. The diff renames one table header in minimal.toml, and the packages and exec lines of that entry do not change. Clobber none: git log on minimal.toml shows no recent fix that this rename reverts. Correctness no workflow, script, test or other minimal.toml refers to the shell session entry by name, so the rename breaks no caller in this repo. AGENTS.md still names shell as an entry of minimal.toml, and that is the one finding. No secret and no dependency change is in the diff. Not checked: that min 0.8 activates a project with a default entry. That behaviour is in the min CLI, not in this repo, and the PR body is the only evidence for it. Not checked: the CLI version of this reviewer, because the command to read it was denied.

Comment thread minimal.toml
minimum_version = "0.0.18"

[sessions.shell]
[sessions.default]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low · AGENTS.md still names shell as an entry of minimal.toml, at line 35 and line 50. After this rename no entry has that name, so the PR body claim that nothing in pkgs refers to shell by name is not correct for the docs. An agent that reads AGENTS.md will look for a shell entry that does not exist. Update both lines to name default, in this PR. The word tasks on those lines was already out of date, because the entries are [sessions.*]. These two lines are the only instances in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

min 0.8: min session activate refuses pkgs — minimal.toml has three session entries and none named default

2 participants

0