Repository navigation
smoke tests: 21 library packages (a–l, batch 1) - #1373
Open
bryan-minimal wants to merge 1 commit into
Open
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
Adds a Standalone smoketest to abseil-cpp at-spi2-core bash-completions biff boost bottom buddy cairo clipper2 cups emacs-config-dev1 eudev flit-core gmp helix-grammars hwdata iana-etc jansson jnv libaom libarchive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 21 billable files and costs up to $5.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 8 minutes for your next included review. View limit details
|
bryan-minimal
added a commit
that referenced
this pull request
Nov 6, 2026
…smoke test Two more findings from the library smoke-test sweep (pkgs#1373-1375): - freetype: configure auto-detects bzip2 from the build closure, so libfreetype.so.6 NEEDS libbz2.so.1.0, but runtime_deps had only glibc and libpng. Linking -lharfbuzz failed on it. (zlib is probably in the same position but the test can't see it: toolchain carries zlib.) - at-spi2-core: libatk-bridge-2.0.so NEEDS libatk-1.0.so.0; atk was missing (chromium-bin lists both, which hid it). harfbuzz gets the compile-link-run test that was held back from #1373 until freetype's fix lands with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Standalonesmoke test to 21 library/data packages from the a–l list with no Standalone test and noOutputBin(batch 1 of 3; batches 1–3 cover 63 packages). Tests are not in the spec hash, so nothing rebuilds.absl::StrCat,-labsl_strings-latspi(atspi_initsymbol) + header presentbash -O extglob -n bash_completion, >100 completion filesbiff --versionprintsbttf <ver>(exit 1 by design, checked by output)BOOST_VERSION+boost::filesystem::current_path(),-lboost_filesystem/usr/bin/btm --versionbdd_init/bdd_ithvar/bdd_satcount,-lbddcairo_image_surface_create+ status,-lcairoUnionof a square, area == 100,-lClipper2ippTagString(IPP_TAG_INTEGER)== "integer",-lcupsudev_new/udev_unref,-ludevpython3 -c 'import flit_core, flit_core.buildapi'(test_deps: python)mpz_pow_ui(2,100)has 101 bits,-lgmp8086 Intel Corporationhttps 443/tcpjson_pack+json_integer_value== 42,-ljansson/usr/bin/jnv --versionaom_codec_version/_str,-laomarchive_write_new+archive_version_number,-larchiveTest design
gcc/g++ -x c - -o t -lX <<EOF … EOF && ./twithtest_deps = [bash-bootstrap, toolchain]. It compiles a tiny program against the installed headers, links it, and runs it, so the library and its wholeDT_NEEDEDclosure must load. Where a real call needs a display or a VM (most X extension libs, libkrunfw, luv), the program takes the symbol's address through avolatilepointer instead. That still links and loads the library.xorgproto(X11/X.h,Xfuncproto.h) and the extension wire headers, so the X tests addxorgprotototest_deps./usr/bin/bashfrom bash-bootstrap, whose only runtime_dep is glibc. There is no coreutils, so the source goes in on gcc's stdin and the file checks use bash builtins. Every script starts withset -e.toolchainitself pulls in zlib, zstd, gmp, mpfr, mpc, libstdc++ and libgcc. A missing runtime_dep on one of those cannot show up in these tests. Every other dependency must come from the package's own runtime_deps closure.How these were verified
Locally, in a fresh
min session activate . --loadout pkgbuildon this branch (a new session name for every run):min package build bash-bootstrap toolchain python fontconfig xorgproto <pkgs>fetches cached artifacts.min check --packages <pkgs>, names space-separated. The full output was read off/run/minenv_sock, because themin checkwrapper prints only the first line of a multi-line test.All tests in this PR report
standalone tests...Pass, and no other check fails. pkgs CI showsstandalone tests...Skipfor them because nothing rebuilds, so the local run is the real evidence.mip dumpisn't available locally, somin check(parse/eval) plus pkgs CI are the evaluation gates. Tests ran on the Mac's VM (arm64); amd64 is not exercised locally.Negative control: in a fresh session,
exit 7was appended to libarchive's test.min checkreportedsmoketest: … exit 7 had exit code 7andstandalone tests...Fail. The development runs also produced real failures: missing headers, a wrong symbol name, and the link errors below. So the tests do run, and failures are reported.Skipped (whole a–l library list; no test added)
Findings (separate PRs: runtime_deps are hashed and trigger a rebuild)
-lharfbuzzfails:libbz2.so.1.0, needed by /lib64/libfreetype.so.6, not foundand undefinedBZ2_bzDecompress*[glibc, libpng]but the library is built with bzip2 support.bzip2is missing. zlib was not checked, because toolchain masks it. This breaks anything that links harfbuzz or freetype without bzip2 happening to be in its closure.-latk-bridge-2.0fails:libatk-1.0.so.0, needed by libatk-bridge-2.0.so, not foundlibatk-bridge-2.0.soneeds libatk, which ships in the separateatkpackage, andatkis not in at-spi2-core's runtime_deps. chromium-bin lists both, which hides it. The test here covers only-latspi.Also noticed, not fixed here: biff, bottom and jnv put their
usr/binexecutables underOutputLib, notOutputBin. That's why they were on the "no OutputBin" list, and enumerate-bins never sees them.🤖 Generated with Claude Code