Repository navigation
tzdata: pin the Vancouver test to fixed instants (BC went permanent UTC-7 today) - #1241
Conversation
…TC-7 today) British Columbia moved to permanent UTC-7 at 2026-11-01T09:00Z, and tzdata names it MST from then on. tz_resolves asserted the CURRENT abbreviation was PST/PDT, so from this morning it fails on every run that executes tzdata's standalone tests: all of #1234-#1240 failed "build failed checks (2 of 18480)", both arches, on this one check. The data is right; the test assumed the rule never changes. Check two pinned 2025 instants instead (PST in January, PDT in July), the same fixed-epoch form as the Paris check below. Tests are not in the SpecHash, so this rebuilds nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Pin abbreviation checks packages/tzdata/build.ncl |
The test checks for PST and PDT at fixed timestamps and documents the abbreviation change. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Suggested reviewers: norrietaylor
Merge Risk: 
8a436
-
No actionable merge-blocking risk remains in this test-only change.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the main change: pinning the Vancouver tzdata test to fixed instants. It is specific and related to the reported British Columbia time-zone change. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Why every PR's build went red this morning
MSTfrom that instant.tzdata's standalone test asserted the current abbreviation isPST/PDT:build failed checks (2 of 18480), one failure per arch. Update eslint to 10.14.0 #1234–Update patchelf to 0.19.3 #1240 all hit it, and so will every queued merge group.Fix
The test now checks two pinned instants instead of "now", using the same fixed-epoch form as the existing Paris check:
@1736899200(2025-01-15) must bePST@1752537600(2025-07-15) must bePDTBoth values were checked against a current zoneinfo. The test still proves the zone and its DST rules resolve.
Tests are not part of the SpecHash, so this rebuilds nothing and the build check should be quick. Once it merges, the failed PRs need
/build(or a re-run) to go green.🤖 Generated with Claude Code
Summary by CodeRabbit
PSTandPDTabbreviations at specific timestamps.