Repository navigation
PASS_WITH_CONDITIONS
Governs (arch 15b603e6. The checkout has no arch-map.md, so I found the sections by search, as the earlier rulings did): architecture.md Types in the identity plane, line 1272. The client submits a digest-bound projection of the expanded spec, and the node recomputes it independently. Store Reference, line 129, and the box.toml [secrets] comment, lines 1013-1019: min writes upstream and inject from [secret-store-rules], never from the author, so the host recomputes the same projection from the spec it receives.
Ruling. This is a re-review against the PASS_WITH_CONDITIONS ruling on 2cf72229. The compare (6bbc56e0) moves the client digest off the encoded wire JSON. It now uses the client's own BoxSpec (stamp_client_projection_digest(request, spec)), so the two digests are two computations and not one. The new test leg mutates a projected wire value after put_spec and shows that the record holds two different digests. This proves the independent recomputation that line 1272 requires (rubric rule 3). The restamp in add_vpn_network_names is gone. That is correct because mfile::projection::project has no vpn_network_names field. min box spec reads the store rules once and passes them to the proxy rows. The Gap: comment names #2410 for the wire. The show.rs and exec-mode test hunks in since.diff come from the merge of main (#3434) and are not in pr.diff. The wire residual stays open against #2410: the create sends v0 BoxSpec, so secret_grants is empty on both sides. C1 only aligns the PR body, which still describes the superseded equal-by-construction design and does not name #2410 as a residual. No departure from precedent.
Not checked: I did not compile. Byte equality of toml::Table::try_from(BoxSpec) and the daemon's Loose JSON-to-TOML read on every BoxSpec shape is argued from the code (both drop nulls) and from the two equal-digest legs of the test. A build settles it. The agent-verify failure (otel_cli exec_run_attach_and_task_run_share_the_commands_trace) is outside the design question, and I did not investigate it.
Conditions
- C1: Edit the
Notes from the agentparagraph of the PR #3441 body so that it matches head 6bbc56e. (1) Replace "the client digest is computed over the BoxSpec JSON that is sent ... The digests are equal by construction" with: the client digest is computed from the client's ownBoxSpec, read as a TOML table, and the daemon recomputes its digest from the JSON it receives. (2) Replace "The digest is stamped in put_spec and again in add_vpn_network_names" with: the digest is set input_speconly, becausenetwork.vpn_network_namesis outside the projection. (3) Name #2410 as the issue for the residual: the create does not send the expanded spec, sosecret_grantsis empty and the store rules do not reach the daemon.
Ruled at 6bbc56e against gominimal/arch@15b603e6afb8 by claude-opus-5-5; arch_rulings 1304, job 50f110fe-910b-4685-8a76-3c37e764d226.