8000 fix(minimal): T52 — A terminal exec's mode is `tty` everywhere by minimal-foundry[bot] · Pull Request #3434 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): T52 — A terminal exec's mode is tty everywhere - #3434

Merged
agent-137 merged 1 commit into
mainfrom
agent/3425-a-terminal-exec-s-mode-is-tty-everywhere
Nov 14, 2026
Merged

agent-137 merged 1 commit into
mainfrom
agent/3425-a-terminal-exec-s-mode-is-tty-everywhere

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

T52 — A terminal exec's mode is tty everywhere

slice: S4
kind: task
covers: BCLI-067, BCLI-033
size: S
est: 5 code, 35 tests
executor: agent
difficulty: routine
model: light
diagnostics: the exec row and the min/v1/exec mode say tty in place of terminal; exec_mode_is_one_word_in_show_and_events pins it, and the four tests listed in the issue move with it
observability: none new
layers:
- client:
- crates/minimal/src/cmd/boxes/show.rs: exec_mode_word names a terminal exec tty, the word its event stores and min box exec --tty takes
- crates/minimal/src/tests.rs: the four tests that pin terminal read tty; a new test checks that the show row, the min/v1/exec JSON and the exec_started event name one exec's mode alike
test: cargo nextest run -p minimal exec_mode_is_one_word_in_show_and_events
produces: none
consumes: none
proof: For an exec started with min box exec -t, min box show, min box show -o json and min box events -o jsonl all name its mode tty.

Proof

For an exec started with min box exec -t, the Live execs: row of min box show, the mode of its min/v1/exec object in min box show -o json, and the data.mode of its exec_started event in min box events -o jsonl all say tty. Before this change, the two show forms said terminal.

Notes from the agent: The four tests that pinned terminal now pin tty: box_show_lists_live_execs, box_show_output_json_writes_box_with_execs, exec_attach_detach_key_returns_0_exec_keeps_running and box_exec_show_logs_wait_stop_end_to_end. They pass, with the attach tests, in one filtered nextest run (23 passed). The test helper write_exec_event now takes the event mode from ExecMode::name(), the spelling the daemon writes, and does not hard-code it. The text row pads the mode to 8 columns, so a tty row reads <id> tty sh -i. cargo clippy -p minimal --all-targets and cargo fmt --check are clean.

Tests

line exit tail
cargo nextest run -p minimal exec_mode_is_one_word_in_show_and_events 0 warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version of minimal? Running task runtime-implement-test-0 in box runtime-implement-test-0-1... Compiling paths v0.0.1 (/workbench/crates/paths) Compiling ot v0.0.1 (/workbench/crates/ot)

Verify

min task run agent-verify exited 100, so this PR is a draft.

 {
                "parent_span_id": "59f1d39a36a2c7dc",
                "rpc": "minimald-v1-GetSessionRecord",
                "span_id": "5d2e0a05f0986c20",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "5d2e0a05f0986c20",
                "queued_behind": "0",
                "span_id": "66b3af11d0b70a85",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "rpc",
            fields: {
                "parent_span_id": "59f1d39a36a2c7dc",
                "rpc": "minimald-v1-DestroySession",
                "span_id": "6e518e4e9750f409",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "GetRecord",
                "parent_span_id": "6e518e4e9750f409",
                "queued_behind": "0",
                "span_id": "d1c384731f7ba91b",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "DeleteSession",
                "parent_span_id": "6e518e4e9750f409",
                "queued_behind": "0",
                "span_id": "20c81b6a63baf4ff",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "session.message",
            fields: {
                "kind": "Destroy",
                "parent_span_id": "20c81b6a63baf4ff",
                "span_id": "cc8255b79b19cf72",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
        LoggedSpan {
            name: "sessions.manager.message",
            fields: {
                "kind": "HandOverName",
                "parent_span_id": "20c81b6a63baf4ff",
                "queued_behind": "0",
                "span_id": "b4bf6afefd8ce92f",
                "trace_id": "0af7651916cd43dd8448eb211c803111",
            },
            parent: None,
            closed: true,
        },
    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
     Summary [  69.156s] 1132 tests run: 1131 passed, 1 failed, 2 skipped
        FAIL [   2.940s] (1132/1132) minimal::otel_cli exec_run_attach_and_task_run_share_the_commands_trace
error: test run failed

Closes #3425

The Live execs row and the min/v1/exec object said terminal, while the
exec_started event and min box exec --tty say tty. Use tty everywhere,
and pin it with exec_mode_is_one_word_in_show_and_events.
@coderabbitai
coderabbitai Bot commented Nov 14, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f38208f9-eb3a-4ea0-a951-c264e846448e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 14, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at b0e613ed41a1.

Nothing to do.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms to the design. Section min box line 498 requires min box show to list live execs, and the design does not give the mode word. The show row and the min/v1/exec object now say tty. That is the word the exec_started event stores and min box exec --tty takes, so one mode has one name. No conditions.

Ruled at b0e613e against gominimal/arch@15b603e6afb8 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — No findings.

Panel: 2 of 3 personas ran (correctness, security); did not complete: supply-chain.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 14, 2026
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 14, 2026
@agent-137
agent-137 added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit a42a9d6 Nov 14, 2026
40 checks passed
@agent-137
agent-137 deleted the agent/3425-a-terminal-exec-s-mode-is-tty-everywhere branch November 14, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T52 — A terminal exec's mode is tty everywhere

2 participants

0