8000 Merge remote-tracking branch 'origin/main' into agent/3402-the-cli-reference-lists-every-min-v1-error-code · gominimal/minimal@b46cf2c · GitHub
[go: up one dir, main page]

Skip to content

Merge remote-tracking branch 'origin/main' into agent/3402-the-cli-re…

Minimal Arch / arch-review succeeded Nov 20, 2026

PASS

Inputs. Re-review of #3667 at b46cf2c3, on arch 8b824707, the same arch as the baseline PASS_WITH_CONDITIONS at 5d4ca537. since-conditions.json carries C1 and C2. No findings.json or arch-map.md is staged. I found the sections by search.

Compare. since.diff is one merge commit, b46cf2c3, of origin/main at 2fd3558e (#3620, #3666, #3677, #3662, #3670). Git recorded a conflict in crates/minimal/src/tests.rs. git show --cc shows that the resolution keeps both sides whole and adds no line of its own. git diff 2fd3558e...b46cf2c3 touches only crates/minimal/src/tests.rs (+219) and docs/reference/cli-min.md (+38). That is the same content that the baseline ruled on. The merge brings in one new MachineModeFailure::new(code, …) site in main.rs (#3670, the daemon-only broker refusal). It takes its code from boxes::core::bep::GATEHOUSE_UNENROLLED_NODE / GITHUB_SIGN_IN_REQUIRED. Both codes are already rows in the reference (exits 5 and 3), and the test reads bep.rs. So the table is still complete. The box wait reference section that #3666 brings in agrees with the wait_timeout row.

Governs: architecture.md Output conventions line 383 (one min/v1/error object on stderr in machine modes) and Exit codes lines 361–370. Ruling: BCLI-033 conforms, as it did at the baseline.

Conditions. C1: met. The PR body has a Residuals heading that links #3680 for the missing usage object on a parse failure. C2: met. The same heading links #3681 for the box show --network not-found exit 1. Both are carried in residuals[]. No condition is open.

Not checked: I did not confirm that #3680 and #3681 exist and have the text the conditions named, because no gh CLI or network is in the sandbox. I did not run cli_reference_lists_every_error_code, because this review does not build. The agent-verify failure in the PR body is exec_run_attach_and_task_run_share_the_commands_trace, which this change does not touch.

Ruled at b46cf2c against gominimal/arch@8b824707cde6 by claude-opus-5-5; arch_rulings 1551, job 18ed2cb3-5049-43ca-bfae-741bcb33d2cb.

0